Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6848 print data matrix barcode labels #6897

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from

Conversation

zachariah-at-msupply
Copy link
Contributor

@zachariah-at-msupply zachariah-at-msupply commented Mar 11, 2025

Fixes #6848

πŸ‘©πŸ»β€πŸ’» What does this PR do?

Changes the format of code used on an asset label from a QR code to a data matrix barcode.

πŸ’Œ Any notes for the reviewer?

20 of the 22 files that were apparently changed are just from merging the issue branch into develop, since I branched it off v2.6.0-RC but now it needs to merge into develop. The two files I actually modified are these:
server/service/src/print/label.rs
server/server/src/print/label.rs

Apart from that, as always...
have a nice day :)

πŸ§ͺ Testing

  • In Open mSupply, go to coldchain > equipment and select an asset (or make one if there are none), and the asset's detail view should appear.
  • Click 'print label' in the top right.
  • If mSupply tells you that you need to set up a printer, these are the details to use (on 11th March 2025):
    - IP = 192.168.1.224
    - port = 9100
  • Check the printed label has the same information on as the mSupply displays for the asset, and make sure it scans, either by using mSupply android or a 2d barcode scanner, or a barcode scanning website (although that's a bit dodgy as you need to give them permission to use your camera).

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked: Any reference to an asset's QR code should be changed to refer to a data matrix barcode instead. Any images of assets' QR codes should be updated to be data matrix barcodes instead (they look like this:)

image

πŸ“ƒ Reviewer Checklist

The PR Reviewer(s) should fill out this section before approving the PR

Breaking Changes

  • No Breaking Changes in the Graphql API
  • Technically some Breaking Changes but not expected to impact any integrations

Issue Review

  • All requirements in original issue have been covered
  • A follow up issue(s) have been created to cover additional requirements

Tests Pass

  • Postgres
  • SQLite
  • Frontend

fergie-nz and others added 29 commits March 4, 2025 10:52
And re add don't duplicate manually created returns
Derive status from whether return has a shipment_id
…ivered-option-of-customer-returns-is-greyed-out-when-it-has-been-created-from-returning-stock-from-another-store

6819 The confirm delivered option of customer returns is greyed out when it has been created from returning stock from another store
…s-to-'Delivered',-the-'Add-item'-button-keeps-disabled,-until-you-click-on-it
…t-when-change-status-to-'Delivered',-the-'Add-item'-button-keeps-disabled,-until-you-click-on-it

6810 Inbound shipment: when change status to 'Delivered', the 'Add item' button keeps disabled, until you click on it
…-from-shipments

Add insert returns as shipped when inserting from shipments
Currently translated at 13.3% (254 of 1903 strings)

Translation: Open mSupply/Common
Translate-URL: https://translate.msupply.org/projects/open-msupply/common/fr-DJ/
@github-actions github-actions bot added this to the v2.7.0 milestone Mar 11, 2025
@github-actions github-actions bot added Team Piwakawaka James, Carl, John, Zachariah, Ferg feature: GAPS labels Mar 11, 2025
@zachariah-at-msupply zachariah-at-msupply changed the title 6848 print 2d datamatrix labels 6848 print data matrix barcode labels Mar 11, 2025
@zachariah-at-msupply zachariah-at-msupply changed the base branch from develop to v2.6.0-RC March 11, 2025 02:13
@zachariah-at-msupply zachariah-at-msupply changed the base branch from v2.6.0-RC to develop March 11, 2025 02:13
Copy link

github-actions bot commented Mar 11, 2025

Bundle size difference

Comparing this PR to main

Old size New size Diff
5.99 MB 5.99 MB 1.04 KB (0.02%)

@zachariah-at-msupply zachariah-at-msupply changed the title 6848 print data matrix barcode labels 6848 print data matrix barcode labels part 1 Mar 11, 2025
@zachariah-at-msupply zachariah-at-msupply changed the title 6848 print data matrix barcode labels part 1 6848 print data matrix barcode labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: GAPS Team Piwakawaka James, Carl, John, Zachariah, Ferg
Projects
None yet
4 participants