6895 don't round displayed prescribed quantity #6909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Team Piwakawaka
Bundle size differenceComparing this PR to
|
fergie-nz
commented
Mar 12, 2025
| @@ -559,7 +557,7 @@ const summarise = ( | |||
| } else { | |||
| counts[packSize] = { | |||
| unitName: (stockLine?.item as ItemNode)?.unitName ?? 'unit', | |||
| count: NumUtils.round(packSize * numberOfPacks), | |||
| count: NumUtils.round(packSize * numberOfPacks, 2), | |||
There was a problem hiding this comment.
Still rounding to 2 to avoid unwieldy numbers
fergie-nz
commented
Mar 12, 2025
| setAbbreviation(''); | ||
| setDefaultDirection(''); | ||
| }, [item?.id]); | ||
| const newIssueQuantity = NumUtils.round(allocatedUnits / Math.abs(Number(packSizeController.selected?.value || 1)), 2); |
There was a problem hiding this comment.
Rounding to 2dp here also to be consistent with other parts of app for input values.
CarlosNZ
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6895
👩🏻💻 What does this PR do?
Removes rounding to no decimals from prescription prescribed quantity display.
💌 Any notes for the reviewer?
You can more easily view changes without new linting changes here
Values passed around retain all information; they were just getting rounded before front end display.
🧪 Testing
📃 Documentation
📃 Reviewer Checklist
The PR Reviewer(s) should fill out this section before approving the PR
Breaking Changes
Issue Review
Tests Pass