Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc chart enhancements and appVersion v1.1.1 #103

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Misc chart enhancements and appVersion v1.1.1 #103

merged 1 commit into from
Dec 3, 2024

Conversation

mtougeron
Copy link
Owner

  • appVersion v1.1.1
  • Allow setting a different namespace for the ServiceMonitor than the one the app runs in
  • Allow setting the DNS config for the pods
  • Allow setting the topologySpreadConstraints
  • Allow setting the priorityClassName
  • Allow not setting the number of replicas for the Deployment in case you set your own HPA or something

jantzenallphin
jantzenallphin approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@jantzenallphin jantzenallphin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mtougeron mtougeron merged commit faf40c4 into main Dec 3, 2024
7 checks passed
@mtougeron mtougeron deleted the chart-app-version-v1.1.1 branch December 3, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantzenallphin jantzenallphin jantzenallphin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtougeron @jantzenallphin