Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Improve JSDoc #16858

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Mar 7, 2025

Based on @LukasTy 's feedback on #16680
I did not cover the entre codebase 😆

@flaviendelangle flaviendelangle added component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels Mar 7, 2025
@mui-bot
Copy link

mui-bot commented Mar 7, 2025

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running pnpm l10n
  • Clean files with pnpm prettier.

Deploy preview: https://deploy-preview-16858--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against ed87494

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 💯

@flaviendelangle flaviendelangle requested a review from LukasTy March 7, 2025 11:36
@flaviendelangle flaviendelangle marked this pull request as ready for review March 7, 2025 11:37
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this. 👍
Let's just run docs:api first. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants