[charts] Add labels above bars example #16860
Draft
+138
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardobelchior
commented
Mar 7, 2025
Comment on lines
+31
to
+40
| export type BarLabelProps = Omit<React.SVGProps<SVGTextElement>, 'ref' | 'id' | 'style'> & | ||
| BarLabelOwnerState & { | ||
| style: Omit<React.SVGProps<SVGTextElement>['style'], 'x' | 'y' | 'height' | 'width'> & | ||
| AnimatedProps<{ | ||
| x: number; | ||
| y: number; | ||
| width: number; | ||
| height: number; | ||
| }>; | ||
| }; |
There was a problem hiding this comment.
I need to do this so that the types are correct, but then TypeScript fails because useSlotProps expects style to be CSSProperties | undefined.
Should I move these properties from the style prop? IMO we should because they aren't spreadable to a normal HTML or SVG element.
We're still in alpha, so we could still make a breaking change, couldn't we?
What do you think, @alexfauquette @JCQuintas?
|
Deploy preview: https://deploy-preview-16860--material-ui-x.netlify.app/ Updated pages: |
bernardobelchior
added
docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add labels above bars example. Related to #12975.