Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Add axis highlight to the radar #16868

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexfauquette
Copy link
Member

Follow up on #16406

Main topics:

  • I did not introduce a rotation-axis entry in the interact. Instead, I reused the x-axis under the assumption that x/y is similar to rotation/radius in practice.
  • I copied the getAxisValue function even though most of the code is similar. Manipulating angles and the fact that 0° and 360° are the same will pollute the main one.

TODO before merging

  • Refine the highlight design
  • Add propose to manage highlight behavior and document it

@alexfauquette alexfauquette added enhancement This is not a bug, nor a new feature component: charts This is the name of the generic UI component, not the React module! labels Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 7, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 7, 2025
@mui-bot
Copy link

mui-bot commented Mar 7, 2025

Deploy preview: https://deploy-preview-16868--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 1c54efa

Copy link

codspeed-hq bot commented Mar 7, 2025

CodSpeed Performance Report

Merging #16868 will not alter performance

Comparing alexfauquette:radar-highlight (1c54efa) with master (3adf6cf)

Summary

✅ 7 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants