[charts] Allow circular grid on radar chart #16870
Open
+143
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
enhancement
|
Deploy preview: https://deploy-preview-16870--material-ui-x.netlify.app/ Updated pages: |
CodSpeed Performance ReportMerging #16870 will not alter performanceComparing Summary
|
bernardobelchior
approved these changes
Mar 10, 2025
| @@ -49,6 +55,7 @@ export default function DemoRadar() { | |||
| '', | |||
| `<RadarChart`, | |||
| ' {/** ... */}', | |||
| ` shape={${props.shape}}`, | |||
There was a problem hiding this comment.
Suggested change
| ` shape={${props.shape}}`, | |
| ` shape="${props.shape}"`, |
| - `divisions` The number of divisions of the grid | ||
| - `startAngle` The rotation angle of the entire chart in degrees. | ||
| - `divisions` The number of divisions of the grid. | ||
| - `shape` The gird shape that can be `circular` or `sharp`. |
There was a problem hiding this comment.
Suggested change
| - `shape` The gird shape that can be `circular` or `sharp`. | |
| - `shape` The grid shape that can be `circular` or `sharp`. |
| import { RadarGridRenderProps } from './RadarGrid.types'; | ||
|
|
||
| export function CircularRadarGrid(props: RadarGridRenderProps) { | ||
| const { center, corners, divisions, radius } = props; |
There was a problem hiding this comment.
Is divisions verified not to be below 1? Not sure if it would create issues when dividing by 0 or a negative number.
| import { useTheme } from '@mui/material/styles'; | ||
| import { RadarGridRenderProps } from './RadarGrid.types'; | ||
|
|
||
| export interface RadarGridProps { |
There was a problem hiding this comment.
Can we remove this type since it's already defined in RadarGrid.types.ts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #16406