Skip to content

replace Codec::from(u64) with TryFrom impl #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2020
Merged

replace Codec::from(u64) with TryFrom impl #44

merged 1 commit into from
Mar 9, 2020

Conversation

@sunny-g
Copy link
Contributor

@sunny-g sunny-g commented Mar 8, 2020

No description provided.

rklaehn
rklaehn approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

vmx
vmx approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @sunny-g.

We are currently in the transition to a license change. Could you please leave a comment that you agree on that change at #25?

@vmx
Copy link
Member

vmx commented Mar 9, 2020

The code coverage failure wasn't introduced by this change, hence merging it.

@vmx vmx merged commit ef94e40 into multiformats:master Mar 9, 2020
@sunny-g
Copy link
Contributor Author

sunny-g commented Mar 9, 2020

I explicitly and publicly agree to the license/contributor changes detailed in #25 :)

rklaehn pushed a commit to Actyx/rust-cid that referenced this pull request May 9, 2020
@austinabell
feat: add support for blake2b256 and blake2s128 (multiformats#44)
9a945bb 
Adds support for blake2b256 and blake2s128.
Guardian88
Guardian88 suggested changes Jan 5, 2021
View reviewed changes
Copy link

@Guardian88 Guardian88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello-wolrd# @all-countributors

@Guardian88
Copy link

Guardian88 commented Jan 5, 2021

Hello-Wolrd# @open-source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmx vmx vmx approved these changes

+2 more reviewers

@rklaehn rklaehn rklaehn approved these changes

@Guardian88 Guardian88 Guardian88 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sunny-g @vmx @Guardian88 @rklaehn