Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request modernizes the Move codebase by updating syntax to use the 2024 edition conventions. The main changes include migrating from the older module declaration syntax to the new syntax, updating dependency revisions to use "mainnet" instead of specific commit hashes, and removing test command options that are no longer available.
- Updated module declarations from
module name { ... }tomodule name;with use statements outside the braces - Changed Sui framework dependency revision from specific commit hash to "mainnet"
- Simplified test command by removing
--statisticsand--coverageflags
Reviewed Changes
Copilot reviewed 23 out of 26 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| run.sh | Simplified sui move test command by removing unsupported flags |
| packages/*/Move.toml | Updated Sui dependency revision from commit hash to "mainnet" |
| packages//sources/.move | Migrated to 2024 edition module syntax |
| packages//tests/.move | Migrated to 2024 edition module syntax and improved formatting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detail
Testing
Documentation
Requested Reviewers: @mention