-
-
Notifications
You must be signed in to change notification settings - Fork 2
Enable ignore by caller inputs #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c5be016
enable ignore by caller inputs
flowerthrower f9749ef
✨ Update CHANGELOG for version 1.18.0
flowerthrower 4717c39
🐍 Fix indentation in cpp-linter workflow to calm pre-commit
flowerthrower 788980d
✨ Update CHANGELOG for version 1.17.3
flowerthrower aea1519
✨ Updated upgrade guide
flowerthrower 9212179
Apply suggestions from code review
flowerthrower 522db10
🎨 pre-commit fixes
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,11 +6,25 @@ This document describes breaking changes and how to upgrade. For a complete list | |
|
|
||
| ## [1.17.3] | ||
|
|
||
| ### Type checking with `ty` | ||
|
|
||
| This release fixes the `ty` linter workflow, which would always use the latest version of `ty` available on PyPI. | ||
| As `ty` is still moving pretty fast and the latest version may not be stable yet, this was not ideal. | ||
| This release changes the behavior to use the version of `ty` listed as a development dependency in `pyproject.toml`. | ||
| If you have the `enable-ty` option set to `true` in your workflow configuration, you **must** add `ty` to your development dependencies or the workflow will fail. | ||
|
|
||
| ### Additional customization for the C++ linter | ||
|
|
||
| This release adds the optional `cpp-linter-ignore-extra` input to the `reusable-cpp-linter.yml` workflow. | ||
| This allows ignoring additional files in the C++ linter workflow by passing a pipe-separated list of globs. | ||
| For example, to ignore all files in the `plugin` directory and the `subdir/third_party` directory, you can use the following configuration: | ||
|
|
||
| ```yaml | ||
| uses: munich-quantum-toolkit/workflows/.github/workflows/[email protected] | ||
| with: | ||
| cpp-linter-ignore-extra: "plugin/**|subdir/third_party/**" | ||
| ``` | ||
|
|
||
| ## [1.17.0] | ||
|
|
||
| This release removes all CodeQL workflows because CodeQL is now run automatically by GitHub. | ||
|
|
@@ -166,7 +180,8 @@ Consider removing any `-G Ninja` flags from your CMake invocations under Windows | |
|
|
||
| <!-- Version links --> | ||
|
|
||
| [unreleased]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.0...HEAD | ||
| [unreleased]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.3...HEAD | ||
| [1.17.3]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.17.0...v1.17.3 | ||
| [1.17.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.16.0...v1.17.0 | ||
| [1.16.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.15.0...v1.16.0 | ||
| [1.15.0]: https://github.com/munich-quantum-toolkit/workflows/compare/v1.14.0...v1.15.0 | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.