feat: expose Classic Bluetooth discovery metadata - #43
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the Android Classic Bluetooth discovery event payload and its TypeScript surface so apps can make better device-type inferences (e.g., likely printers) using native discovery metadata beyond just device name.
Changes:
- Expands the
classicDeviceFoundevent payload to include optional RSSI, Bluetooth Class of Device (CoD) info, service-class flags, and cached SDP UUIDs. - Adds exported TypeScript interfaces (
ClassicDevice,ClassicBluetoothClass) and updates theBluetoothEventMaptyping accordingly. - Updates README documentation to describe the new fields and their reliability/availability constraints.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/index.ts | Exports new Classic discovery interfaces and updates classicDeviceFound event typing to ClassicDevice. |
| README.md | Documents new classicDeviceFound metadata fields and provides a usage example plus reliability notes. |
| android/src/main/java/com/munimbluetooth/HybridMunimBluetooth.kt | Emits enriched Classic discovery payload including RSSI, BluetoothClass details, and cached UUIDs (with SecurityException handling for UUID access). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
classicDeviceFoundClassicDeviceandClassicBluetoothClassTypeScript interfacesWhy
Applications such as POS and label-printing clients need native hints to distinguish likely printers from unrelated Classic Bluetooth devices without relying only on device names.
Validation
npm run build./gradlew :app:compileDebugKotlinagainst Android API 36git diff --check