Fix crash on opening specific file #26705
Open
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we could get a crash in `StringData::fretChords` at `bUsed[nNewString]++;`, because `nNewString` would still be -1 at that point. (Such crash would be seen in the file from musescore#26696.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #26696
There were two different problems, fixed in two different commits, and I'm not very confident about both of them.
For the Volta one, I'd think that code should not even be called at all when
effectiveStaffIdxis muse::nidx, but I found it difficult to figure out where to put such a check.For the StringData one, I have no idea why that
ifcondition was there, and I'm also not very certain about the consequences of this change, but at least it fixes this particular crash...