Ensure the first keySig is properly flagged as Header #26792
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Feb 27, 2025
|
@mike-spa I found a regression (comparing with master) in this case (watch with sound): bandicam.2025-02-27.15-57-23-185.mp4I'm using Insert command added to the 1st measure |
mike-spa
force-pushed
the
fixFirstHeaderKeySigNotRemoved
branch
from
057bda5 to
b13a48a
Compare
|
@DmitryArefiev I have tried a different solution. Can you let me know if you find any more issues? Anyway, this proves that this part of code is extremely delicate, so I'd like to merge this in master but definitely not in 4.5, so I'm going to remove it from 4.5 @oktophonie FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #22324