-
Notifications
You must be signed in to change notification settings - Fork 3k
Add option for "invert score" to follow app theme #27750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for "invert score" to follow app theme #27750
Conversation
|
It might be easier on the eyes if the black background was dark grey instead. Maybe add a "high contrast" option for deep black? |
I tend to agree, but that's out of the scope of this PR (which is just adding the option to follow the app theme; the color inversion option was there before). |
1059780 to
19d5f80
Compare
19d5f80 to
fabc828
Compare
|
Thanks for working on this @Reedbeta and apologies for the delay. We'd love to include this in 4.7 but with some tweaks to how the new option is presented in the UI. Long message incoming but I promise it's nothing super complex! Here's the plan:
So the default state of the 'Appearance' page in Preferences will looks like this: Here's the spacing of the new UI: Here's a prototype of the interaction: Screen.Recording.2025-10-21.at.3.48.27.PM.movAnd here are some other UI copy tweaks we'd like to make on this page while we're at it, if you don't mind updating these too. These are already reflected in the designs above, but to point them out more clearly here's a screenshot of the old design noting what should be changed: If you see this and aren't available to work on this in the coming weeks, just let us know if you don't mind. Thanks so much! |
Thanks for following up. It sounds straightforward enough. I can probably find some time to work on this. |
fabc828 to
61bd4f5
Compare
|
@avvvvve I've pushed an update to the PR with my changes. I think I've implemented everything you asked for; give it a whirl when you have a chance. 🙂 |
bkunda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work as expected (tested on macOS). Thank you @Reedbeta.
As an aside, it seems like a missed opportunity here if we make this one tweak to "invert score" but don't try to more generally improve how it actually looks. The current white on black is extremely hard on the eyes, and the lack of customisability means if you don't like it, you just can't use it.
If we were to at least fine-tune the colours in invert mode (using greys instead of pure black/white) – and perhaps even add colour palette pickers in the advanced tab for customisability – then this would be a feature we could actually talk-up/promote.
@jessjwilliamson any colour suggestions you have would be appreciated here.
|
Ah I see my suggestion was already made above (should have read the thread). I realise it's out of scope for this PR, but if we were to think more holistically about improvements to this feature that will make the biggest impact in the next release, I'd strongly encourage rounding-off this improvement with better colour options. Otherwise, the reaction will be "why was this change made, but the colours still look ugly?". |
|
I've made the color change in #30997. I will now review and merge this PR. |
0af0e13 to
791c6cf
Compare
|
Thanks for the fixes and cleanup, @cbjeukendrup! I noticed that the |
into NotationConfiguration. It has evolved into a UI setting, with the possibility to follow the app theme, and as such does not fit in the engraving module anymore. The engraving module only needs to know whether a certain paint action should use inverted colors or not; that info is passed in via PaintOptions.
214e8ee to
bcfb1d9
Compare
|
Oops, yes, good catch. I had accidentally initially based my changes on an old version of the PR because I forgot I had checked out the branch earlier. I've squashed your commit into mine for a clean history. |



This PR adds the option for "invert score" to follow the app theme: that is, automatically turning on when the app theme is dark, and off when it's light.
In the Appearance preferences, a new checkbox has been added per the design in this comment.