Skip to content

add multi-window support to accessibility system#32797

Open
kryksyh wants to merge 1 commit intomusescore:masterfrom
kryksyh:multi-window_accessibility
Open

add multi-window support to accessibility system#32797
kryksyh wants to merge 1 commit intomusescore:masterfrom
kryksyh:multi-window_accessibility

Conversation

@kryksyh
Copy link
Copy Markdown
Contributor

@kryksyh kryksyh commented Mar 26, 2026

  • Adds app-wide accessibility root, which owns all windows within the same process
  • AccessibilityConfiguration was removed since it is no longer needed
  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@kryksyh kryksyh requested a review from Eism March 26, 2026 17:34
@kryksyh kryksyh force-pushed the multi-window_accessibility branch 5 times, most recently from c2517b1 to 55b597b Compare March 26, 2026 19:15
}

return accessibilityConfiguration()->isAccessibleEnabled();
return navigationController()->activeSection() != nullptr;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What confuses me is:

  • This reveals the logic for enabling accessibility, i.e. the logic described here is not the logic for enabling accessibility specifically in the engraving module, but the logic for the entire application.
  • If we need this value somewhere, we will either have to repeat this logic or ask the engraving, which will be strange.
  • Now the engraving module depends on and knows about the navigation controller.

I propose to bring back iaccessibilitycontextconfiguration

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that this logic is duplicated in AccessibilityController, we can use it instead of iaccessibilitycontextconfiguration

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that this logic is duplicated in AccessibilityController, we can use it instead of iaccessibilitycontextconfiguration

Yes, you are right. My motivation to remove AccessibilyConfiguration was the fact that isAccessibleEnabled is not a configuration, but a current runtime state.
I replaced it with a call to AcecssibilityController

- Adds app-wide accessibility root, that owns all windows within the same process
- AccessibilityConfiguration was removed since it is no longer needed
@kryksyh kryksyh force-pushed the multi-window_accessibility branch from 55b597b to f00e037 Compare March 27, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants