add multi-window support to accessibility system#32797
Open
kryksyh wants to merge 1 commit intomusescore:masterfrom
Open
add multi-window support to accessibility system#32797kryksyh wants to merge 1 commit intomusescore:masterfrom
kryksyh wants to merge 1 commit intomusescore:masterfrom
Conversation
Contributor
kryksyh
commented
Mar 26, 2026
- Adds app-wide accessibility root, which owns all windows within the same process
- AccessibilityConfiguration was removed since it is no longer needed
- I signed the CLA
- The title of the PR describes the problem it addresses
- Each commit's message describes its purpose and effects, and references the issue it resolves
- If changes are extensive, there is a sequence of easily reviewable commits
- The code in the PR follows the coding rules
- There are no unnecessary changes
- The code compiles and runs on my machine, preferably after each commit individually
- I created a unit test or vtest to verify the changes I made (if applicable)
c2517b1 to
55b597b
Compare
| } | ||
|
|
||
| return accessibilityConfiguration()->isAccessibleEnabled(); | ||
| return navigationController()->activeSection() != nullptr; |
Contributor
There was a problem hiding this comment.
What confuses me is:
- This reveals the logic for enabling accessibility, i.e. the logic described here is not the logic for enabling accessibility specifically in the engraving module, but the logic for the entire application.
- If we need this value somewhere, we will either have to repeat this logic or ask the engraving, which will be strange.
- Now the engraving module depends on and knows about the navigation controller.
I propose to bring back iaccessibilitycontextconfiguration
Contributor
There was a problem hiding this comment.
I saw that this logic is duplicated in AccessibilityController, we can use it instead of iaccessibilitycontextconfiguration
Contributor
Author
There was a problem hiding this comment.
I saw that this logic is duplicated in AccessibilityController, we can use it instead of iaccessibilitycontextconfiguration
Yes, you are right. My motivation to remove AccessibilyConfiguration was the fact that isAccessibleEnabled is not a configuration, but a current runtime state.
I replaced it with a call to AcecssibilityController
- Adds app-wide accessibility root, that owns all windows within the same process - AccessibilityConfiguration was removed since it is no longer needed
55b597b to
f00e037
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.