all: prepare for v0.18.0-rc1 release #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using recursive watching, a very large synchronization root could block endpoint scan calls from preempting because they would be blocked trying to acquire the scan lock, which would be held by the watching Goroutine while it tried to perform its initial scan. This could make session termination hang. To fix this, we switch to a semaphore-based scan lock that allows for preemption. Termination of the session still behaves correctly because the watching Goroutine context is still cancelled and synchronization/core.Scan will preempt correctly. Signed-off-by: Jacob Howard <[email protected]>
Signed-off-by: Jacob Howard <[email protected]>
Signed-off-by: Jacob Howard <[email protected]>
Signed-off-by: Jacob Howard <[email protected]>
Signed-off-by: Jacob Howard <[email protected]>
Signed-off-by: Jacob Howard <[email protected]>
Signed-off-by: Jacob Howard <[email protected]>
This doesn't have a practical impact, since scan cancellation indicates that an endpoint is shutting down anyway, but it's a more "correct" return value. Signed-off-by: Jacob Howard <[email protected]>
Signed-off-by: Jacob Howard <[email protected]>
xenoscopic
force-pushed
the
v018-development
branch
from
d2e4508 to
ac52470
Compare
This was referenced Apr 29, 2024
Something seems to have changed with macOS' FAT32 implementation with macOS 14 that is causing FAT32-related tests to fail. We need to investigate further, but this shouldn't affect most users. Moreover, something also seems broken with macOS 13's base64 command (it doesn't like long-form flags like --output). Signed-off-by: Jacob Howard <[email protected]>
xenoscopic
force-pushed
the
v018-development
branch
from
15cc200 to
29d5d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do and why is it needed?
This PR prepares for the v0.18.0-rc1 release. It primarily includes dependency updates, but also a few changes to scan preemption.