-
Couldn't load subscription status.
- Fork 61
Add MENU_ITEM constant to template to allow styling of menu items with CSS #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add `menu-item` to the `exportparts` list so that the menu-item elements can be styled
|
@jarred is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this!
Just a little request could you update the themes gerwig and classic and add exportpart <media-time-range exportparts="thumb" ... for the thumb can be styled from the light DOM?.
|
Hi @ronalduQualabs ! No problem, have done so. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
==========================================
+ Coverage 70.73% 70.75% +0.02%
==========================================
Files 37 37
Lines 6677 6685 +8
Branches 498 499 +1
==========================================
+ Hits 4723 4730 +7
- Misses 1951 1952 +1
Partials 3 3
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
Currently menu items appear like they can be targeted and styled with
mux-player::part(menu-item)but this fails because the partmenu-itemis not included in the list of parts to export.Menu item markup
Theme parts exported
Also noticed
thumbmissing too, to allow for styling the thumb in the volume and time ranges.Could someone please point me in the right direction if this isn't the place to suggest this. Thanks!