Skip to content

Conversation

ronalduQualabs
Copy link
Contributor

Resolves 1193 by adding two new cases in the attributeChangedCallback of the base of the player:

  1. DISABLE_TRACKING: Reloads the player when this attribute changes, since tracking must be disabled on initialization (keeping the currentTime and playbackState).
  2. DISABLE_COOKIES: Deletes the tracking cookie if the attribute is changed after initialization.

These changes allow the user disable this tracking props on the run without breaking he experience of playing the video.

Copy link

vercel bot commented Oct 17, 2025

@ronalduQualabs is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

snyk-io bot commented Oct 17, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.70%. Comparing base (75451bb) to head (be0cb5e).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
- Coverage   70.73%   70.70%   -0.03%     
==========================================
  Files          37       37              
  Lines        6676     6683       +7     
  Branches      498      498              
==========================================
+ Hits         4722     4725       +3     
- Misses       1951     1955       +4     
  Partials        3        3              

see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Is react player not reactive with respect to tracking props?

1 participant