Improve Condition Rendering Extensibility #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditions are no longer rendered via a Visitor, so the new name makes more sense
Conditions are no longer rendered via a Visitor, so the new name makes more sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditions can now override the "renderCondition" method to change how the condition is rendered.
This change makes it possible to alter the rendering of conditions. Previously, the rendering algorithm was hard-coded into a visitor and could not be altered easily. With this change, we retain the default behavior from before but also allow custom conditions to override the default behavior.
This change also renames the "VisitableCondition" interface to "RenderableCondition" because conditions are no longer rendered via a visitor. The prior name is kept and deprecated for now to provide some assistance for code migration in the event anyone has created a direct implementation of VisitableCondition. Custom conditions that extend one of the abstract base classes (AbstractSingleValueCondition. etc.) should have no changes required.
Resolves #916