Make host url configurable from UI#205
Open
ikorihn wants to merge 6 commits intomyzhan:masterfrom
Open
Conversation
myzhan
reviewed
Aug 21, 2024
| } | ||
|
|
||
| // Update the host URL passed from UI | ||
| boomer.Events.Subscribe(boomer.EVENT_SPAWN3, func(workers int, spawnRate float64, host string) { |
Owner
There was a problem hiding this comment.
what about a more understandable name like boomer.EVENT_CONFIG?
|
|
||
| numClients int32 | ||
| spawnRate float64 | ||
| targetHost string |
Owner
There was a problem hiding this comment.
I don't want to keep this field. Publishing an event is enough.
| func (r *runner) startSpawning(spawnCount int, spawnRate float64, spawnCompleteFunc func()) { | ||
| func (r *runner) startSpawning(spawnCount int, spawnRate float64, host string, spawnCompleteFunc func()) { | ||
| Events.Publish(EVENT_SPAWN, spawnCount, spawnRate) | ||
| Events.Publish(EVENT_SPAWN3, spawnCount, spawnRate, host) |
Owner
There was a problem hiding this comment.
What about Events.Publish(EVENT_CONFIG, "host", host)?
Author
There was a problem hiding this comment.
I have modified the code to publish the boomer:config event along with a map f090ff9 .
Is this what you meant?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #177, this PR allows boomer to receive the host url configured in master UI.
When boomer receives the spawn message including
hostfield, it publishes a newboomer:spawn3event.