feat: update to iroh@1.0.0-rc.1#47
Conversation
| //! A read-only iroh-blobs store that imports data from HTTP(S) URLs (such as | ||
| //! S3 buckets) into an in-memory store. | ||
| //! | ||
| //! Data is downloaded into memory at import time, the outboard is computed | ||
| //! once, and the entry is served from memory thereafter. This is a thin | ||
| //! wrapper around [`iroh_blobs::store::mem::MemStore`] that adds the | ||
| //! convenience [`S3Store::import_url`] method. |
There was a problem hiding this comment.
Uhm what. Does that actually do what the original example did?
This is what its readme writes:
This works by downloading the content and computing an outboard in memory.
The data itself remains remote.
The current implementation doesn't really do that... it stores the data in-memory.
(Stopped reviewing the rest of iroh-s3-bao-store due to that for now.)
There was a problem hiding this comment.
Yeah, maybe we should just remove the example instead. The previous example was based on iroh-blobs 0.35 which had a very different store API. Recreating it on current iroh-blobs should be done properly. We should keep it as-is and add a note to the README, or remove it for now (but then in a separate PR please so that it can be easily reverted).
Frando
left a comment
Frando
left a comment
There was a problem hiding this comment.
Let's revert the iroh-s3-bao-store changes for now and leave it at 0.35, maybe add a note to the readme that it is outdated atm. (I did not review the new impl, but assume that it was an LLM attempt at porting it. Might be good, but let's leave this to a separate PR please so that it can be properly discussed independent of the other changes in the PR).
The rest LGTM from a read over the diff (did not actually run anything).
…hook lands The iroh-blobs 0.102 actor-based Store does not expose a trait-based extension point for a custom data backend, so the original "outboard in memory, data stays remote" design cannot be preserved.
matheus23
left a comment
matheus23
left a comment
There was a problem hiding this comment.
Just need to address Frando's concern about the comment, otherwise LGTM!
- content-discovery-cli: pkarr+DNS lookup is provided by presets::N0; the previous docstring was correct, drop the misleading addendum - iroh-s3-bao-store: soften the pin note — porting to iroh-blobs 0.102 is future work, not impossible
3 participants
No description provided.