feat!: Split up the metrics feature into metrics and service
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allows compiling to Wasm *with* the `metrics` feature flag.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-metrics/pr/11/docs/iroh_gossip/ Last updated: 2025-02-25T11:30:48Z |
Arqu
approved these changes
Feb 25, 2025
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splits up the
metricsfeature intometricsandservice. Onlymetricsis a default feature flag now.This also allows compiling to Wasm with the
metricsfeature flag.Breaking Changes
metricsfeature flag was reduced and some of its functionality split into theservicefeature flag.If you used default feature flags and the service functionality specifically, enable the non-default
servicefeature flag now.Change checklist