feat(n8n AWS Cognito Node): New node #11767

valentina98 · 2024-11-17T16:25:52Z

Summary

Added new node for the AWS Cognito API.
https://docs.aws.amazon.com/cognito-user-identity-pools/latest/APIReference/Welcome.html

The following operations were implemented for the specific resources:

Resource: User Pool

Get

Resource: User

Create
Get
Delete
Get Many
Update
Add to Group
Remove from Group

Resource: Group

Create
Delete
Get
Get Many
Update

Joffcom · 2024-11-17T16:30:35Z

Hey @valentina98,

Thanks for the PR, We have created "GHC-455" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

codecov · 2024-11-25T13:31:11Z

Codecov Report

Attention: Patch coverage is 36.45833% with 244 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...base/nodes/Aws/Cognito/generalFunctions/helpers.ts	11.42%	62 Missing ⚠️
...s/Aws/Cognito/generalFunctions/presendFunctions.ts	56.86%	43 Missing and 1 partial ⚠️
...nodes/Aws/Cognito/generalFunctions/dataFetching.ts	58.97%	26 Missing and 6 partials ⚠️
...e/nodes/Aws/Cognito/generalFunctions/pagination.ts	0.00%	25 Missing ⚠️
...nodes/Aws/Cognito/generalFunctions/dataHandling.ts	0.00%	24 Missing ⚠️
...odes/Aws/Cognito/generalFunctions/errorHandling.ts	45.94%	15 Missing and 5 partials ⚠️
.../nodes/Aws/Cognito/descriptions/UserDescription.ts	0.00%	13 Missing ⚠️
...nodes/Aws/Cognito/descriptions/GroupDescription.ts	0.00%	11 Missing ⚠️
...es/nodes-base/nodes/Aws/Cognito/AwsCognito.node.ts	0.00%	7 Missing ⚠️
...es/Aws/Cognito/descriptions/UserPoolDescription.ts	0.00%	3 Missing ⚠️
... and 1 more

📢 Thoughts on this report? Let us know!

…into node-aws-cognito

Parvezkhan0 · 2025-01-22T07:05:36Z

packages/nodes-base/credentials/Aws.credentials.ts

@@ -354,6 +354,7 @@ export class Aws implements ICredentialType {
 				} else if (service === 'rekognition' && credentials.rekognitionEndpoint) {


Add validation to ensure service is defined and valid before constructing the endpoint string.

Parvezkhan0 · 2025-01-22T07:07:12Z

packages/nodes-base/nodes/Aws/Cognito/AwsCognito.node.ts

+		hints: [
+			{
+				message: 'Please select a parameter in the options to update the user',
+				displayCondition:
+					'={{$parameter["resource"] === "user" && $parameter["operation"] === "update" && Object.keys($parameter["additionalOptions"]).length === 0}}',
+				whenToDisplay: 'always',
+				location: 'outputPane',
+				type: 'warning',
+			},
+			{


Use concise messages like "Select a parameter to update this resource" to improve clarity.

adina-hub · 2025-01-24T15:44:37Z

@Parvezkhan0 @netroy this node is still in a review phase, please wait for confirmation to continue.

netroy · 2025-01-24T15:45:50Z

packages/nodes-base/credentials/Aws.credentials.ts

@@ -353,8 +353,6 @@ export class Aws implements ICredentialType {
 					endpointString = credentials.sesEndpoint;
 				} else if (service === 'rekognition' && credentials.rekognitionEndpoint) {
 					endpointString = credentials.rekognitionEndpoint;
-				} else if (service === 'sqs' && credentials.sqsEndpoint) {


why are these lines removed?

It was a duplicate, there was also a comment previously with this as a to-do

…into node-aws-cognito

ShireenMissi · 2025-02-19T12:12:55Z

packages/nodes-base/credentials/Aws.credentials.ts

@@ -339,7 +339,7 @@ export class Aws implements ICredentialType {
 				region = parsed.region;
 			}
 		} else {
-			if (!requestOptions.baseURL && !requestOptions.url) {
+			if (!requestOptions.baseURL && !requestOptions.url && service) {


This check is redundant

Suggested change

if (!requestOptions.baseURL && !requestOptions.url && service) {

if (!requestOptions.baseURL && !requestOptions.url) {

packages/nodes-base/credentials/test/Aws.credentials.test.ts

ShireenMissi · 2025-02-19T14:46:04Z

packages/nodes-base/nodes/Aws/Cognito/AwsCognito.node.ts

+		hints: [
+			{
+				message: 'Select a parameter to update this resource',
+				displayCondition:
+					'={{$parameter["resource"] === "user" && $parameter["operation"] === "update" && Object.keys($parameter["additionalOptions"]).length === 0}}',
+				whenToDisplay: 'always',
+				location: 'outputPane',
+				type: 'warning',
+			},
+			{
+				message: 'Select a parameter to update this resource',
+				displayCondition:
+					'={{$parameter["resource"] === "group" && $parameter["operation"] === "update" && Object.keys($parameter["options"]).length === 0}}',
+				whenToDisplay: 'always',
+				location: 'outputPane',
+				type: 'warning',
+			},
+		],


do these hints work? also there is so much duplication between the two

@ShireenMissi is this good?

ShireenMissi · 2025-02-19T14:48:01Z

packages/nodes-base/nodes/Aws/Cognito/AwsCognito.node.ts

+		outputs: [NodeConnectionType.Main],
+		hints: [
+			{
+				message: 'Select a parameter to update this resource',


@gandreini isn't this message very generic?

@ShireenMissi yes too generic. Looking at the code it seems that this is fired when I update a user and send no data. We could rephrase it as Select at least one user field to update
Same for the warning below about the group

ShireenMissi · 2025-02-19T14:59:00Z

packages/nodes-base/nodes/Aws/Cognito/GenericFunctions.ts

+/* eslint-disable n8n-local-rules/no-uncaught-json-parse */
+/* eslint-disable @typescript-eslint/no-unsafe-assignment */
+/* eslint-disable @typescript-eslint/no-unsafe-member-access */


please don't disable rules like this

Suggested change

/* eslint-disable n8n-local-rules/no-uncaught-json-parse */

/* eslint-disable @typescript-eslint/no-unsafe-assignment */

/* eslint-disable @typescript-eslint/no-unsafe-member-access */

ShireenMissi · 2025-02-19T15:37:22Z

packages/nodes-base/nodes/Aws/Cognito/GenericFunctions.ts

+					});
+				}
+			}
+		}


the error mapping can be simplified and extracted
for example you could use

const errorMapping: Record<string, Record<string, { message: string; description: string }>> = { group: { delete: { message: 'The group you are deleting could not be found.', description: 'Adjust the "Group" parameter setting to delete the group correctly.', }, ....

ShireenMissi · 2025-02-19T15:41:10Z

packages/nodes-base/nodes/Aws/Cognito/GenericFunctions.ts

+	return data;
+}
+
+export async function awsRequest(


for naming consistency I suggest renaming this to

Suggested change

export async function awsRequest(

export async function makeAwsRequest(

ShireenMissi · 2025-02-19T16:04:53Z

packages/nodes-base/nodes/Aws/Cognito/GenericFunctions.ts

The code in this file is complex and could be significantly simplified. It is hard to read due to excessive type casting, some of which are unnecessary. Additionally, API calls, such as checking if a user is in a group, could be optimised for better readability and efficiency.

ShireenMissi

Could you please update the PR descriptions with details about the changes you made for example what Node was added and all resources/operations
Additionally on the User resource/ Update I find the attributes part hard to fill without checking the API docs

I think the standard attributes https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-settings-attributes.html these should be added as named options, and [name, value] pairs can be kept for any custom attributes

adina-hub · 2025-03-10T06:42:13Z

Could you please update the PR descriptions with details about the changes you made for example what Node was added and all resources/operations Additionally on the User resource/ Update I find the attributes part hard to fill without checking the API docs I think the standard attributes https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-settings-attributes.html these should be added as named options, and [name, value] pairs can be kept for any custom attributes
I implemented this , is this a good approach? @gandreini

ShireenMissi · 2025-03-10T21:47:42Z

Could you please update the PR descriptions with details about the changes you made for example what Node was added and all resources/operations Additionally on the User resource/ Update I find the attributes part hard to fill without checking the API docs I think the standard attributes https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-settings-attributes.html these should be added as named options, and [name, value] pairs can be kept for any custom attributes
I implemented this , is this a good approach? @gandreini

@adina-hub Thanks for making the changes, what I meant by my comment is actually adding the following options directly so users don't have to look up the API docs to update them
name
family_name
given_name
middle_name
nickname
preferred_username
profile
picture
website
gender
birthdate
zoneinfo
locale
updated_at
address
email
phone_number
sub

Co-authored-by: Shireen Missi <[email protected]>

adina-hub · 2025-03-11T06:12:33Z

@ShireenMissi the code is ready for review.

Initial commit

f9ad3bc

n8n-assistant bot added community Authored by a community member node/improvement New feature or request node/new Creation of an entirely new node in linear Issue or PR has been created in Linear for internal review labels Nov 17, 2024

Stamsy and others added 3 commits November 22, 2024 13:13

add error handle function

48ebf1f

add group description

f7d39b6

Added User description

133ba47

adina-hub and others added 16 commits November 26, 2024 14:09

Edit User description

d1bbde9

update group description

9d2b604

Merge branch 'node-aws-cognito' of https://github.com/digital-boss/n8n …

bcc479e

…into node-aws-cognito

add search method to get group from list

6eb585d

Updated User description

e85ced0

update group description logic

8fcfc4c

Merge branch 'node-aws-cognito' of https://github.com/digital-boss/n8n …

61d63b9

…into node-aws-cognito

Added more fields for create action

39d4d9d

Merge branch 'node-aws-cognito' of https://github.com/digital-boss/n8n …

b4406c4

…into node-aws-cognito

add process response group

c57f838

Worked on error handling and pagination

f09091a

Worked on pagination function

e4088ca

Removed some ToDos

6914c11

Fixed pagination

477bbbc

Changes after feedback

3615cd9

Fixed issues after feedback

3f15fd5

valentina98 changed the title ~~WIP: feat(n8n AWS Cognito Node): New node~~ feat(n8n AWS Cognito Node): New node Dec 14, 2024

Stamsy and others added 3 commits December 15, 2024 19:30

add handle pagination and aws request unit tests

c667116

add unit test for other functions in generic function file

9fa6985

Merge branch 'node-aws-cognito' of https://github.com/digital-boss/n8n …

f3bcf18

…into node-aws-cognito

adina-hub added 2 commits January 13, 2025 12:02

Fixed last tests for search functions

27a3ab6

Made some changes on processAttributes function test

f8b090b

Parvezkhan0 reviewed Jan 22, 2025

View reviewed changes

Added validation for services and prefix to response variable

56a6cb1

netroy reviewed Jan 24, 2025

View reviewed changes

gandreini and others added 10 commits January 30, 2025 10:13

Minor copy tweaks.

8244972

Fixed issues after feedback

2fc9e95

User output changes

98e6280

Modified available groups for removeUserFromGroup & fixed updateUser

1d596fc

Fixed tests

d050efb

Removed comments

442f30b

Minor copy tweak.

b28298f

Fixed users actions based on sign-in attributes and tests

70d3369

Description change

2fbeb9f

Merge branch 'node-aws-cognito' of https://github.com/digital-boss/n8n …

316269f

…into node-aws-cognito

ShireenMissi requested changes Feb 19, 2025

View reviewed changes

Joffcom mentioned this pull request Feb 21, 2025

oauth 2 token is not getting refreshed automatically #13413

Closed

ShireenMissi requested changes Feb 21, 2025

View reviewed changes

adina-hub added 3 commits February 27, 2025 13:45

Fixed issues after review

b3eadad

Improved code

1b17c57

Removed comments

a3add6e

adina-hub added 3 commits March 10, 2025 15:49

Improved functions

80883f9

Fixed tests

9407738

Fixed build issue

b8c7bd8

adina-hub and others added 2 commits March 11, 2025 08:03

Fixed lint issues

aaf3a31

Update credentials file

8181b3c

Co-authored-by: Shireen Missi <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(n8n AWS Cognito Node): New node #11767

feat(n8n AWS Cognito Node): New node #11767

valentina98 commented Nov 17, 2024 •

edited

Loading

Joffcom commented Nov 17, 2024

codecov bot commented Nov 25, 2024 •

edited

Loading

Parvezkhan0 Jan 22, 2025

Parvezkhan0 Jan 22, 2025

adina-hub commented Jan 24, 2025 •

edited

Loading

netroy Jan 24, 2025

adina-hub Jan 24, 2025

ShireenMissi Feb 19, 2025

ShireenMissi Feb 19, 2025

adina-hub Mar 10, 2025

ShireenMissi Feb 19, 2025

gandreini Feb 19, 2025

ShireenMissi Feb 19, 2025

ShireenMissi Feb 19, 2025

ShireenMissi Feb 19, 2025

ShireenMissi Feb 19, 2025

ShireenMissi left a comment

adina-hub commented Mar 10, 2025 •

edited

Loading

ShireenMissi commented Mar 10, 2025

adina-hub commented Mar 11, 2025

		@@ -354,6 +354,7 @@ export class Aws implements ICredentialType {
		} else if (service === 'rekognition' && credentials.rekognitionEndpoint) {

	if (!requestOptions.baseURL && !requestOptions.url && service) {
	if (!requestOptions.baseURL && !requestOptions.url) {

	/* eslint-disable n8n-local-rules/no-uncaught-json-parse */
	/* eslint-disable @typescript-eslint/no-unsafe-assignment */
	/* eslint-disable @typescript-eslint/no-unsafe-member-access */

	export async function awsRequest(
	export async function makeAwsRequest(

feat(n8n AWS Cognito Node): New node #11767

Are you sure you want to change the base?

feat(n8n AWS Cognito Node): New node #11767

Conversation

valentina98 commented Nov 17, 2024 • edited Loading

Summary

Joffcom commented Nov 17, 2024

codecov bot commented Nov 25, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adina-hub commented Jan 24, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShireenMissi left a comment

Choose a reason for hiding this comment

adina-hub commented Mar 10, 2025 • edited Loading

ShireenMissi commented Mar 10, 2025

adina-hub commented Mar 11, 2025

valentina98 commented Nov 17, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading

adina-hub commented Jan 24, 2025 •

edited

Loading

adina-hub commented Mar 10, 2025 •

edited

Loading