Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AWS SES Node): Encode template parameters properly #13570

Merged
merged 5 commits into from
Mar 11, 2025

Conversation

riascho
Copy link
Contributor

@riascho riascho commented Feb 27, 2025

This PR ensures proper encoding for the template params used in createTemplate and updateTemplate. This is to improve the handling of special characters being passed in.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@riascho riascho changed the title fix(AwsSes) Node: Encode template parameters properly fix(AwsSes Node): Encode template parameters properly Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/nodes-base/nodes/Aws/SES/AwsSes.node.ts 28.57% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ShireenMissi ShireenMissi changed the title fix(AwsSes Node): Encode template parameters properly fix(Aws Ses Node): Encode template parameters properly Feb 27, 2025
@ShireenMissi ShireenMissi changed the title fix(Aws Ses Node): Encode template parameters properly fix(Awsses Node): Encode template parameters properly Feb 27, 2025
@ShireenMissi ShireenMissi changed the title fix(Awsses Node): Encode template parameters properly fix(AWS SES Node): Encode template parameters properly Feb 27, 2025
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Feb 27, 2025
@riascho riascho force-pushed the node-2475-aws-ses-node-create-template-bug branch 2 times, most recently from 40101a5 to 4771701 Compare March 3, 2025 11:39
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually and it works, just need to fix the unit tests

@ShireenMissi ShireenMissi force-pushed the node-2475-aws-ses-node-create-template-bug branch from 4771701 to 1cb4d4a Compare March 11, 2025 14:56
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Mar 11, 2025

n8n    Run #9699

Run Properties:  status check passed Passed #9699  •  git commit 1cb4d4a0e0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 riascho 🗃️ e2e/*
Project n8n
Branch Review node-2475-aws-ses-node-create-template-bug
Run status status check passed Passed #9699
Run duration 04m 42s
Commit git commit 1cb4d4a0e0: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 riascho 🗃️ e2e/*
Committer Shireen Missi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 441
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit ca8d249 into master Mar 11, 2025
38 checks passed
@ShireenMissi ShireenMissi deleted the node-2475-aws-ses-node-create-template-bug branch March 11, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants