-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AWS SES Node): Encode template parameters properly #13570
fix(AWS SES Node): Encode template parameters properly #13570
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
40101a5
to
4771701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested manually and it works, just need to fix the unit tests
4771701
to
1cb4d4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
n8n
|
Project |
n8n
|
Branch Review |
node-2475-aws-ses-node-create-template-bug
|
Run status |
|
Run duration | 04m 42s |
Commit |
|
Committer | Shireen Missi |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
5
|
|
0
|
|
441
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
This PR ensures proper encoding for the template params used in
createTemplate
andupdateTemplate
. This is to improve the handling of special characters being passed in.Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)