-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Popping logs out into a new window #13788
base: master
Are you sure you want to change the base?
Changes from all commits
94e2cc2
4c12c94
2684cea
b075112
d6b9f41
563249a
5e75c3e
c46fc26
1f73539
41f2af1
d1f8a15
5111dd3
daa9f6d
6c21992
a1a83a8
5950bd7
a5c82ec
8be9125
e4049a1
fe174e7
7b11538
ef1a101
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changes in this file are needed to show tooltips properly in a PiP window. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import type { ElTooltip } from 'element-plus'; | ||
import { computed, type ComputedRef, inject, type InjectionKey, provide } from 'vue'; | ||
|
||
const TOOLTIP_APPEND_TO = 'TOOLTIP_APPEND_TO' as unknown as InjectionKey<Value>; | ||
|
||
type Value = ComputedRef<InstanceType<typeof ElTooltip>['$props']['appendTo']>; | ||
|
||
export function useProvideTooltipAppendTo(el: Value) { | ||
provide(TOOLTIP_APPEND_TO, el); | ||
} | ||
|
||
export function useInjectTooltipAppendTo(): Value { | ||
const injected = inject( | ||
TOOLTIP_APPEND_TO, | ||
computed(() => undefined), | ||
); | ||
|
||
return injected; | ||
} |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed with product to remove the confirmation dialog of clearing the chat history. In the future we'll need to make the dialog work in PiP window as well. Right now it always shows in the main window even when the user is interacting in PiP window. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this file makes it possible to listen to the right window object when the resizer is used in a PiP window