fix: Do not trigger sendAndWait response on bot visit if response type is approval #13792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
node/improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
dana-gill
requested changes
Mar 10, 2025
…google-chat-send-and-wait
dana-gill
requested changes
Mar 11, 2025
|
|
||
| const result = await sendAndWaitWebhook.call(mockWebhookFunctions); | ||
|
|
||
| expect(result).toEqual({ noWebhookResponse: true }); |
There was a problem hiding this comment.
Could you also add a test for testing that res.send gets called with ''? :)
…google-chat-send-and-wait
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
node-2485-google-chat-send-and-wait
|
| Run status |
|
| Run duration | 04m 39s |
| Commit |
|
| Committer | Michael Kret |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
441
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not trigger sendAndWait response on bot visit if response type is approval
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-2485/google-chat-send-and-wait#comment-8def3048
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)