refactor(core): Improve UX on permission errors (no-changelog) #13795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
netroy
force-pushed
the
improve-permission-errors
branch
from
fd835a8 to
c5d3773
Compare
netroy
force-pushed
the
improve-permission-errors
branch
from
c5d3773 to
a688e95
Compare
ivov
reviewed
Mar 10, 2025
packages/cli/src/workflow-helpers.ts
Outdated
| error: NodeApiError | NodeOperationError | WorkflowOperationError, | ||
| node: INode, | ||
| error: ExecutionError, | ||
| node: INode | undefined, |
There was a problem hiding this comment.
Do we know in which cases we can have a node-less error?
There was a problem hiding this comment.
when SubworkflowPolicyChecker.check throws
netroy
force-pushed
the
improve-permission-errors
branch
from
8f39efb to
40d9c33
Compare
ivov
previously approved these changes
Mar 11, 2025
packages/cli/src/executions/__tests__/execution.service.test.ts
Outdated
Show resolved
Hide resolved
| @Service() | ||
| export class PermissionChecker { | ||
| export class CredentialsPermissionChecker { |
Co-authored-by: Iván Ovejero <[email protected]>
ivov
previously approved these changes
Mar 11, 2025
|
|
ivov
approved these changes
Mar 11, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
master
|
| Run status |
|
| Run duration | 04m 41s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
441
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the execution permission errors UX by
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)