Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Tweak schema view empty state copy and styling #13819

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Mar 11, 2025

Summary

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1632/schema-view-search-empty-state-copy-tweak-and-harmonisation

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@dana-gill dana-gill requested a review from ShireenMissi March 11, 2025 09:01
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rontend/editor-ui/src/components/VirtualSchema.vue 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Mar 11, 2025
ShireenMissi
ShireenMissi previously approved these changes Mar 11, 2025
Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Mar 11, 2025

n8n    Run #9704

Run Properties:  status check failed Failed #9704  •  git commit e9d05a529e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-1632-schema-view-search-empty-state-copy-tweak-and-harmonisation
Run status status check failed Failed #9704
Run duration 05m 10s
Commit git commit e9d05a529e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 440
View all changes introduced in this branch ↗︎

Tests for review

Failed  e2e/5-ndv.cy.ts • 1 failed test

View Output Video

Test Artifacts
NDV > should show additional tooltip when seaching in schema view if no matches Screenshots Video
Flakiness  e2e/39-projects.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Projects > when starting from scratch > should create sub-workflow and credential in the sub-workflow in the same project Test Replay Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants