Skip to content

Fix/do not bellow #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ClarkMcGrew wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/do not bellow #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c11d9b3
Fix a "wow" spelling mistake
ClarkMcGrew Jul 30, 2025
dc976db
Fix usage of deprecated method
ClarkMcGrew Jul 30, 2025
f21f76b
Clarify deprecation message
ClarkMcGrew Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/GenericToolbox.Macro.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#endif // HAS_CPP_11


//#define WARN_DEPRECATED_FCT
#define WARN_DEPRECATED_FCT /* Always flag deprecation */
#ifndef WARN_DEPRECATED_FCT
#define GT_DEPRECATED(msg_) // nothing
#else
Expand Down
5 changes: 3 additions & 2 deletions include/GenericToolbox.Utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,11 +422,12 @@ namespace GenericToolbox{
[[nodiscard]] bool hasBound() const{ return hasLowerBound() or hasUpperBound(); }
[[nodiscard]] bool hasBothBounds() const{ return hasLowerBound() and hasUpperBound(); }
[[nodiscard]] bool isUnbounded() const{ return not hasBound(); }
[[nodiscard]] bool isBellowMin(double val_) const{ return (hasLowerBound() and val_ < min); }
[[nodiscard]] bool isBelowMin(double val_) const{ return (hasLowerBound() and val_ < min); }
[[nodiscard]] GT_DEPRECATED("replace with isBelowMin()") bool isBellowMin(double val_) const { return isBelowMin(val_); }
[[nodiscard]] bool isAboveMax(double val_) const{ return (hasUpperBound() and val_ > max); }
[[nodiscard]] bool isInBounds(double val_) const{
// both bounds are inclusive [min, max]
if( isBellowMin(val_) ){ return false; }
if( isBelowMin(val_) ){ return false; }
if( isAboveMax(val_) ){ return false; }
return true;
}
Expand Down