New log subscription #217
Open
New log subscription #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christeredvartsen
force-pushed
the
logs
branch
from
f134af3 to
1e16f97
Compare
thokra-nav
reviewed
Oct 10, 2025
internal/loki/loki.go
Outdated
| u := q.baseURL | ||
| u.Path = "/loki/api/v1/tail" | ||
|
|
||
| since := -1 * time.Hour |
There was a problem hiding this comment.
Suggested change
| since := -1 * time.Hour | |
| since := 1 * time.Hour |
Siden vi gjør -since i .Add() på linje 60?
thokra-nav
reviewed
Oct 10, 2025
thokra-nav
reviewed
Oct 10, 2025
thokra-nav
reviewed
Oct 10, 2025
internal/graph/schema/log.graphqls
Outdated
|
|
||
| Defaults to 1 hour. | ||
| """ | ||
| since: Duration |
There was a problem hiding this comment.
Skulle vi hatt datetime i stedetfor en duration? Det lar oss i f.eks. frontenden kunne linke til logger. Eller gir det ikke mening på en subscription?
thokra-nav
reviewed
Oct 10, 2025
internal/graph/schema/log.graphqls
Outdated
| """ | ||
| Initial batch of past log lines before streaming starts. Defaults to 100. | ||
| """ | ||
| limit: Int |
There was a problem hiding this comment.
Bytte navn fra limit til f.eks. initialBatch? Limit navnet tolker jeg som at subscription vil avslutte etter 100 linjer
thokra-nav
reviewed
Oct 10, 2025
We initially added the transport since the one from gqlgen did not have support for ping. It has since gotten support for ping, so we no longer need our custom one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initiativ: https://github.com/nais/o11y/pull/43