When using valkey, also add REDIS-prefixed env-variables

This makes the transition from redis to valkey easier for the teams, as they don't have to change anything in their code.
This also allows using the URI env variable with redis libraries that expect a rediss scheme, by using the REDIS_URI_ env variables instead of VALKEY_URI_.

Made all the REDIS variables optional, to make it easier when we start removing anything Redis related at some later point.

Author: mortenlj

pkg/resourcecreator/aiven/valkey.go

@@ -26,6 +26,9 @@ func Valkey(ast *resource.Ast, config Config, source Source, aivenApp *aiven_nai
 		}
 
 		addValkeyEnvVariables(ast, aivenApp.Spec.SecretName, valkey.Instance)
+		// Make the transition easier for teams coming from Redis by setting the `REDIS_` env variables too
+		addRedisEnvVariables(ast, aivenApp.Spec.SecretName, valkey.Instance)
+
 		aivenApp.Spec.Valkey = append(aivenApp.Spec.Valkey, &aiven_nais_io_v1.ValkeySpec{
 			Instance: valkey.Instance,
 			Access:   valkey.Access,

pkg/resourcecreator/testdata/valkey.yaml

@@ -55,6 +55,33 @@ tests:
                 containers:
                   - name: "myapplication"
                     env:
+                      - name: REDIS_USERNAME_NAISTEST1
+                        valueFrom:
+                          secretKeyRef:
+                            key: REDIS_USERNAME_NAISTEST1
+                            name: ^aiven-myapplication-.{8}-\d{4}-\d\d?-0$
+                      - name: REDIS_PASSWORD_NAISTEST1
+                        valueFrom:
+                          secretKeyRef:
+                            key: REDIS_PASSWORD_NAISTEST1
+                            name: ^aiven-myapplication-.{8}-\d{4}-\d\d?-0$
+                      - name: REDIS_URI_NAISTEST1
+                        valueFrom:
+                          secretKeyRef:
+                            key: REDIS_URI_NAISTEST1
+                            name: ^aiven-myapplication-.{8}-\d{4}-\d\d?-0$
+                      - name: REDIS_HOST_NAISTEST1
+                        valueFrom:
+                          secretKeyRef:
+                            key: REDIS_HOST_NAISTEST1
+                            name: ^aiven-myapplication-.{8}-\d{4}-\d\d?-0$
+                            optional: true
+                      - name: REDIS_PORT_NAISTEST1
+                        valueFrom:
+                          secretKeyRef:
+                            key: REDIS_PORT_NAISTEST1
+                            name: ^aiven-myapplication-.{8}-\d{4}-\d\d?-0$
+                            optional: true
                       - name: VALKEY_USERNAME_NAISTEST1
                         valueFrom:
                           secretKeyRef: