Pass rollout reason annotation to deployment

[sechmann]

When the Application resource is annotated with the kubernetes.io/change-cause annotation, it would be nice to annotate the deployment resource as well. Annotating the deployment resource does not create a new replicaset.

https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#checking-rollout-history-of-a-deployment

[kimtore]

OK, I suppose it is okay to try this then.

[kimtore]

Looks good. Can you write in the commit/merge message what the purpose of the merge is, as you explained earlier?

[jhrv]

Good idea, I agree that we should pass the value on to the deployment to enhance the rollout history view. With this in place, we should also populate this with deployd.
I don't understand why it's useful to include the change cause in the hash.

[sechmann]

I don't understand why it's useful to include the change cause in the hash.

It's useful if you want to add a change-cause after the actual change.
The examples in the referenced documentation are like this: kubectl annotate deployment.v1.apps/nginx-deployment kubernetes.io/change-cause="image updated to 1.9.1"
which would not trigger a resync for us, and thus never reaching the deployment annotations.

[jhrv]

Makes sense 👍 lgtm