-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReleaseChannel CRD #429
base: main
Are you sure you want to change the base?
Conversation
dccb72b
to
a8bd329
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR adds a new ReleaseChannel CustomResourceDefinition and updates the API types, tests, and RBAC configurations to support managing release channels for Unleash deployments.
- Introduces the ReleaseChannel CRD with validation schemas and printer columns.
- Adds API types and tests for ReleaseChannel functionality and integrates it with Unleash deployments.
- Updates RBAC rules and generated deepcopy code along with package renaming to “v1”.
Reviewed Changes
File | Description |
---|---|
charts/unleasherator-crds/templates/releasechannel-crd.yaml | New CRD definition for ReleaseChannel with detailed schema |
api/v1/releasechannel_types.go | API types for ReleaseChannel and associated methods |
api/v1/releasechannel_types_test.go | Tests for candidate and update behavior |
charts/unleasherator/templates/releasechannel-editor-rbac.yaml | RBAC configuration for ReleaseChannel editing |
api/v1/zz_generated.deepcopy.go | Regenerated deepcopy functions and package renaming |
charts/unleasherator/templates/unleash-crd.yaml | Updated CRD for Unleash including releaseChannel properties |
api/v1/unleash_types.go | Updates to Unleash API including a new Image resolution logic |
charts/unleasherator/templates/manager-rbac.yaml | Addition of RBAC rules for releasechannel resources |
(Other package renaming diffs in various test and API type files) | Package updates from unleash_nais_io_v1 to v1 |
Copilot reviewed 83 out of 83 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
api/v1/zz_generated.deepcopy.go:5
- Verify that the package name change from 'unleash_nais_io_v1' to 'v1' is reflected consistently across all files and autogenerated code to avoid potential mismatches.
package v1
api/v1/apitoken_types.go:7
- Ensure that the import path update for the utils package is intentional and that all references to the old 'pkg/utils' package path have been updated project-wide.
import ( ... "github.com/nais/unleasherator/internal/utils"
api/v1/unleash_types.go:356
- [nitpick] Since 'CustomImage' is defined as a UnleashImage type (alias for string), consider comparing it to UnleashImage("") for clarity and type consistency.
if u.Spec.CustomImage != "" {
Create a new CRD for ReleaseChannel