Skip to content

Conversation

@r-zane-spalding
Copy link

Issue Number

Currently the group.height property is stated in the docs as being able to be set and override the calculated group height. However, this capability is currently not implemented. This PR implements that capability.

Overview of PR

  • tests/utils/calendar/get-ordered-groups-with-items.js
    • This test file had the wrong name in the describe block. Fixed that.
  • tests/utils/calendar/snapshots/get-ordered-groups-with-items.js.snap
    • Snapshot test modified due to name change in describe block above
  • tests/utils/calendar/get-group-with-item-dimensions.js
    • Added test to cover new functionality
  • src/lib/utility/calendar.js
    • Implemented capability. If the group height is not undefined, use it. If it is undefined, calculate.

Don't forget to update the CHANGELOG.md file with any changes that are in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant