NC-5747: Align method with web-sdk #353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namidan
requested changes
Nov 15, 2024
Contributor
namidan
left a comment
namidan
left a comment
There was a problem hiding this comment.
Looks like removeAllListeneres was only added to the Android bridge, and not iOS bridge or NamiPaywallManager ts
Contributor
Author
It was by mistake. I guess we don't need to add that method in RN as mobile SDKs are handling this internally |
Contributor
Author
|
@namidan For now, kept other buySkuComplete methods to avoid backward compatibility crashes, should we remove them now? |
cp-sumi-k
force-pushed
the
nc-5747-align-method-with-web-sdk
branch
from
ec18cd0 to
10452b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isEntitlementActivebuySkuCompletemethod inNamiPaywallManager