Skip to content

Add README for generics public preview #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Apr 21, 2025

Description

  • Add links to both main README files.
  • Expand targets tables to include preview versions.
  • Minor formating fixes.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Summary by CodeRabbit

  • Documentation
    • Introduced comprehensive documentation on public preview support for C# generics in .NET nanoFramework, including usage instructions, tooling updates, and known issues.
    • Added dedicated sections in both English and Chinese README files announcing generics preview support and linking to detailed documentation.
    • Updated firmware tables in the README files to include preview version badges and download links for supported boards.

- Add links to both main README files.
- Expand targets tables to include preview versions.
- Minor formating fixes.
Copy link

coderabbitai bot commented Apr 21, 2025

Walkthrough

This update introduces documentation and README changes to announce and explain the public preview of generics support in the .NET nanoFramework CLR. A new dedicated document, README-GENERICS.md, provides comprehensive details on generics usage, firmware and tooling updates, and known issues. The main and Chinese README files are updated to highlight the availability of preview firmware with generics support, including new sections and additional columns in firmware tables to display preview version badges and links. No code or API changes are present; all modifications are in documentation and presentation.

Changes

File(s) Change Summary
README-GENERICS.md New documentation file added describing generics support, usage, requirements, and known issues.
README.md, README.zh-cn.md Added sections announcing generics preview, updated firmware tables with preview columns and badges, and made minor formatting adjustments.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Documentation
    participant Firmware
    participant Tooling

    User->>Documentation: Reads about generics support and preview instructions
    User->>Tooling: Updates Visual Studio extension and NuGet packages as instructed
    User->>Firmware: Installs preview firmware with generics support
    User->>Documentation: Refers to known issues and feedback channels
Loading

Possibly related PRs

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (5)
README.md (2)

18-22: Minor punctuation improvement in new preview section
Add a comma for clarity in the sentence on line 21.
Suggested change:

- If you want to use this feature please refer to the documentation [here](README-GENERICS.md).
+ If you want to use this feature, please refer to the documentation [here](README-GENERICS.md).
🧰 Tools
🪛 LanguageTool

[typographical] ~21-~21: It seems that a comma is missing.
Context: ...enerics. If you want to use this feature please refer to the documentation [here](READM...

(IF_PLEASE_COMMA)


40-40: Remove stray semicolon in separator line
The line -----; appears to include an unintended semicolon and may disrupt Markdown rendering. It should be:

- -----;
+ -----
README.zh-cn.md (1)

18-21: Remove trailing spaces after Chinese sentence
Line 20 ends with two spaces; remove the extra whitespace to clean up formatting.

README-GENERICS.md (2)

42-43: Clarify comparative phrasing
The clause “similarly to how they would on the full .NET runtime” lacks an explicit verb and may read awkwardly.
Suggested revision:

- …write more flexible and reusable code on microcontrollers, similarly to how they would on the full .NET runtime.
+ …write more flexible and reusable code on microcontrollers, similar to how they can on the full .NET runtime.
🧰 Tools
🪛 LanguageTool

[grammar] ~42-~42: It seems that a verb is missing.
Context: ...microcontrollers, similarly to how they would on the full .NET runtime. Keep in mind ...

(MD_DT_JJ)


75-75: Add hyphens for compound adjectives
Use hyphens in “pre- and post-generics projects” for correct compound adjective styling.
Suggested revision:

- …not possible to support pre and post generics projects…
+ …not possible to support pre‑ and post‑generics projects…
🧰 Tools
🪛 LanguageTool

[grammar] ~75-~75: It appears that hyphens are missing.
Context: ...extension, it's not possible to support pre and post generics projects with the same extension. There...

(PRE_AND_POST_NN)


[grammar] ~75-~75: It appears that hyphens are missing.
Context: ...ersions. It is not an option to install pre and post generics extensions in VS2019 and VS2022, for ex...

(PRE_AND_POST_NN)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c2c71d1 and 5adc2fd.

📒 Files selected for processing (3)
  • README-GENERICS.md (1 hunks)
  • README.md (4 hunks)
  • README.zh-cn.md (2 hunks)
🧰 Additional context used
🪛 LanguageTool
README.zh-cn.md

[style] ~119-~119: Using many exclamation marks might seem excessive (in this case: 90 exclamation marks for a text that’s 39429 characters long)
Context: ...-|---|---| | TI_CC1352R1_LAUNCHXL_868 | Latest Version @ Cloudsmith | Latest Version @ Cloudsmith | | TI_CC1352R1_LAUNCHXL_915 | Latest Version @ Cloudsmith | Latest Version @ Cloudsmith | | TI_CC3220SF_LAUNCHXL | [![Latest Version @ Cloudsmith](https://ap...

(EN_EXCESSIVE_EXCLAMATION)

README.md

[typographical] ~21-~21: It seems that a comma is missing.
Context: ...enerics. If you want to use this feature please refer to the documentation [here](READM...

(IF_PLEASE_COMMA)


[style] ~131-~131: Using many exclamation marks might seem excessive (in this case: 91 exclamation marks for a text that’s 43399 characters long)
Context: ...-|---|---| | TI_CC1352R1_LAUNCHXL_868 | Latest Version @ Cloudsmith | Latest Version @ Cloudsmith | | TI_CC1352R1_LAUNCHXL_915 | Latest Version @ Cloudsmith | Latest Version @ Cloudsmith | | TI_CC3220SF_LAUNCHXL | [![Latest Version @ Cloudsmith](https://ap...

(EN_EXCESSIVE_EXCLAMATION)

README-GENERICS.md

[grammar] ~42-~42: It seems that a verb is missing.
Context: ...microcontrollers, similarly to how they would on the full .NET runtime. Keep in mind ...

(MD_DT_JJ)


[grammar] ~75-~75: It appears that hyphens are missing.
Context: ...extension, it's not possible to support pre and post generics projects with the same extension. There...

(PRE_AND_POST_NN)


[grammar] ~75-~75: It appears that hyphens are missing.
Context: ...ersions. It is not an option to install pre and post generics extensions in VS2019 and VS2022, for ex...

(PRE_AND_POST_NN)

🔇 Additional comments (11)
README.md (1)

44-45: Preview column added correctly
The new “Preview” column header and its alignment row are clear and consistent with existing table formatting.

README.zh-cn.md (1)

32-33: 新增“预览”列标题格式正确
表头新增的“预览”列及其对齐符号符合 Markdown 规范,清晰易读。

README-GENERICS.md (9)

1-4: Great new documentation file
The title and overview section clearly introduce the purpose and context of the generics public preview.


5-12: Clear explanation of generics benefits
The bullet points for type safety, reusability, and performance are well‑written and concise.


13-25: Well‑formed generic method example
The sample code for Max<T> demonstrates usage effectively and follows standard C# conventions.


27-38: Effective generic class illustration
The Stack<T> class example is simple, accurate, and easy to follow.


44-58: Firmware flashing instructions are clear
The nanoff --preview example and notes accurately guide users through applying preview firmware.


61-70: VSIX installation steps are well detailed
The instructions for downloading and installing the preview Visual Studio extension are precise and user‑friendly.


77-86: NuGet package update guidance is solid
The steps for enabling prerelease packages and aligning versions are clear and actionable.


88-98: Feedback and known issues section is comprehensive
The caveats around debugging quirks and memory usage set proper expectations for users.


99-100: Strong closing call to action
The thank‑you note and invitation for feedback provide a positive wrap‑up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants