Fix #2781, guard server-only TIME message ID - #2790
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
sylvesterkaczmarek
marked this pull request as ready for review
August 13, 2026 10:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fix #2781.
Guard the
SEND_CMD_MIDdeclaration and initialization inCFE_TIME_TaskPipe()withCFE_PLATFORM_TIME_CFG_SERVER.SEND_CMD_MIDis only used by the server-onlyCFE_TIME_ToneSendCmd()dispatch path. In a TIME client configuration, the previous unconditional declaration and initialization left a server-only static variable unused, which causes strict client builds to fail.Testing performed
modules/time/fsw/src/cfe_time_dispatch.c.CFE_PLATFORM_TIME_CFG_SERVER == truecondition.Expected behavior changes
SEND_CMD_MIDvariable.System(s) tested on
Additional context
The patch intentionally keeps the declaration, initialization, and use of
SEND_CMD_MIDunder the same server-only compile-time condition.Third party code
None.
Contributor Info - All information REQUIRED for consideration of pull request
Sylvester Kaczmarek, Personal