Skip to content

Fix #2781, guard server-only TIME message ID - #2790

Open
sylvesterkaczmarek wants to merge 1 commit into
nasa:devfrom
sylvesterkaczmarek:fix-2781-time-client-build
Open

Fix #2781, guard server-only TIME message ID#2790
sylvesterkaczmarek wants to merge 1 commit into
nasa:devfrom
sylvesterkaczmarek:fix-2781-time-client-build

Conversation

@sylvesterkaczmarek

@sylvesterkaczmarek sylvesterkaczmarek commented Aug 12, 2026

Copy link
Copy Markdown

Checklist (Please check before submitting)

Describe the contribution

Fix #2781.

Guard the SEND_CMD_MID declaration and initialization in CFE_TIME_TaskPipe() with CFE_PLATFORM_TIME_CFG_SERVER.

SEND_CMD_MID is only used by the server-only CFE_TIME_ToneSendCmd() dispatch path. In a TIME client configuration, the previous unconditional declaration and initialization left a server-only static variable unused, which causes strict client builds to fail.

Testing performed

  1. Verified the change is limited to the server-only message ID declaration and initialization in modules/time/fsw/src/cfe_time_dispatch.c.
  2. Verified the existing server-only use remains under the same CFE_PLATFORM_TIME_CFG_SERVER == true condition.
  3. Upstream GitHub Actions are currently awaiting authorization for this fork PR, so no CI result is being claimed yet.

Expected behavior changes

  • API Change: none.
  • Behavior Change: TIME client builds no longer compile the unused server-only SEND_CMD_MID variable.
  • TIME server dispatch behavior is unchanged.

System(s) tested on

  • The issue was reported on RHEL 9.x, x86_64, using the native_std build.
  • This PR is awaiting NASA GitHub Actions authorization for repository CI validation.

Additional context

The patch intentionally keeps the declaration, initialization, and use of SEND_CMD_MID under the same server-only compile-time condition.

Third party code

None.

Contributor Info - All information REQUIRED for consideration of pull request

Sylvester Kaczmarek, Personal

@sylvesterkaczmarek
sylvesterkaczmarek marked this pull request as ready for review August 13, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cFE TIME cfe_time_dispatch.c compilation error when configured as a client

2 participants