Skip to content

feat: add support vue3 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add support vue3 #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions package.json.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"workspaces": [
"packages/*",
"demo-vue",
"demo-vue3",
"demo-ng",
"demo-svelte",
"demo-react",
Expand Down Expand Up @@ -32,6 +33,9 @@
"demo.vue.android": "cd ./demo-vue && ns run android --no-hmr --env.watchNodeModules",
"demo.vue.clean": "cd ./demo-vue && ns clean",
"demo.vue.ios": "cd ./demo-vue && ns run ios --no-hmr --env.watchNodeModules",
"demo.vue3.android": "cd ./demo-vue3 && ns run android --no-hmr --env.watchNodeModules",
"demo.vue3.clean": "cd ./demo-vue3 && ns clean",
"demo.vue3.ios": "cd ./demo-vue3 && ns run ios --no-hmr --env.watchNodeModules",
"doc": "node tools/builddoc.mjs",
"publish": "npm run clean && npm run build.all && npm run readme && npm run doc && lerna publish --no-private --create-release=github --force-publish",
"postinstall": "npm run setup",
Expand Down
6 changes: 3 additions & 3 deletions readme/demos-and-development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ WARNING: it seems `yarn build.all` wont always work (not finding binaries in `no
### Demos

```bash
npm run demo.[ng|react|svelte|vue].[ios|android]
npm run demo.[ng|react|svelte|vue|vue3].[ios|android]

npm run demo.svelte.ios # Example
```

Demo setup is a bit special in the sense that if you want to modify/add demos you dont work directly in `demo-[ng|react|svelte|vue]`
Instead you work in `demo-snippets/[ng|react|svelte|vue]`
Demo setup is a bit special in the sense that if you want to modify/add demos you dont work directly in `demo-[ng|react|svelte|vue|vue3]`
Instead you work in `demo-snippets/[ng|react|svelte|vue|vue3]`
You can start from the `install.ts` of each flavor to see how to register new demos

## Contributing
Expand Down
8 changes: 7 additions & 1 deletion sync.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,17 @@ if (!pluginDemos.includes('svelte')) {
deleteProperty(pluginPackageJSON, 'demo.svelte.clean');
}

if (!pluginDemos.includes('vue')) {
if (!pluginDemos.endsWith('vue')) {
deleteProperty(pluginPackageJSON, 'demo.vue.android');
deleteProperty(pluginPackageJSON, 'demo.vue.ios');
deleteProperty(pluginPackageJSON, 'demo.vue.clean');
}

if (!pluginDemos.includes('vue3')) {
deleteProperty(pluginPackageJSON, 'demo.vue3.android');
deleteProperty(pluginPackageJSON, 'demo.vue3.ios');
deleteProperty(pluginPackageJSON, 'demo.vue3.clean');
}

console.log('Common files and package.json have been synced.');
fs.writeFileSync('./package.json', JSON.stringify(pluginPackageJSON, 0, 4) + '\n');
2 changes: 1 addition & 1 deletion update.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const { execSync } = require('child_process');

const pluginConfig = fs.readFileSync('config.json');

const validDirectories = ['tools', 'demo-ng', 'demo-react', 'demo-svelte', 'demo-vue'];
const validDirectories = ['tools', 'demo-ng', 'demo-react', 'demo-svelte', 'demo-vue', 'demo-vue3'];

function getDirectories(path) {
return fs.readdirSync(path).filter(function (file) {
Expand Down