Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: used diff. node-toggl-api package fixing upcoming API change #26

Merged
merged 6 commits into from
May 20, 2021

Conversation

natterstefan
Copy link
Owner

@natterstefan natterstefan commented May 19, 2021

Issue

What I did

What it adds, solves and/or improves

  • added new intermittent package, that will (should) be replaced in the future to a new and maintained npm package

How to test

At the moment travis is failing, because of #27, that is why you have to test this change manually.

  • build the package with npx vsce package
  • install the generated *.vsix extension manually
  • test the app

@natterstefan natterstefan added bug Something isn't working enhancement New feature or request labels May 19, 2021
@natterstefan natterstefan self-assigned this May 19, 2021
@natterstefan natterstefan marked this pull request as ready for review May 20, 2021 18:44
@natterstefan natterstefan changed the title fix: use different node-toggl-api package to fix upcoming API breaking fix: used diff. node-toggl-api package fixing upcoming API change May 20, 2021
@natterstefan natterstefan merged commit f61e660 into master May 20, 2021
@natterstefan natterstefan deleted the fix/toggl-api-domain branch May 20, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant