-
Notifications
You must be signed in to change notification settings - Fork 28
Added support for pnpm package manager #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| function getCommand(action) { | ||
| // Derived from pnpm-audit-report | ||
| // TODO: share the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks familiar. Is this comment section true?
| } | ||
| } | ||
|
|
||
| module.exports = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like it's any different from npm. Is this just 'p' added to every 'npm' in the code, or I missed the changes?
Is that enough for it to work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naugtur PNPM commands are almost similar to NPM. It works. We are using my fork in production.
|
Thanks! I should have included pnpm a long time ago. IS it really that similar to npm? If so, I don't see the point in copy-pasting the code, I'd just add the missing 'p' conditionally to the commands form the original implementation. |
|
@naugtur in last 5 months, I haven't seen any difference in NPM and PNPM commands. |
|
@naugtur This appears to be dead, what can I do to get this moving again? npm audit --json --omit=devpnpm audit --json --prod |
This PR is too add support for PNPM package manager.