-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Check code examples with axe #3168
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ import type { PlaywrightTestConfig } from "@playwright/test"; | |
import { devices } from "@playwright/test"; | ||
import path from "path"; | ||
|
||
const smoketestMatcher = /smoketest(-\w+)?\.test\.ts/; | ||
//const smoketestMatcher = /smoketest(-\w+)?\.test\.ts/; | ||
/** | ||
* See https://playwright.dev/docs/test-configuration. | ||
*/ | ||
|
@@ -46,10 +46,11 @@ const config: PlaywrightTestConfig = { | |
...devices["Desktop Chrome"], | ||
}, | ||
...(process.env.FULL_TEST | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we're going to have the same test suite run for both cases, we could also just remove this |
||
? { testMatch: [/.*\.e2e\.(ts|tsx)/] } | ||
: { testMatch: [smoketestMatcher, /search.e2e.ts/] }), | ||
? { testMatch: [/axe\.e2e\.(ts|tsx)/] } | ||
: { testMatch: [/axe.e2e.ts/] }), | ||
}, | ||
{ | ||
// TODO: Revert all changes to this file | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Guessing this is WIP stuff? (there's a lot of comments that we could probably strip as well before this goes live / un-draft the PR) :D There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this branch is WIP and not ready for review. But ideas/suggestions are welcome! |
||
/* { | ||
name: "Safari", | ||
use: { | ||
...devices["Desktop Safari"], | ||
|
@@ -62,7 +63,7 @@ const config: PlaywrightTestConfig = { | |
...devices["iPhone 12"], | ||
}, | ||
testMatch: [smoketestMatcher], | ||
}, | ||
}, */ | ||
|
||
/* { | ||
name: "firefox", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SEO manglet kanskje her? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La til den fordi axe klaget på at
<title>
manglet.