[Aksel.nav.no] ✨ Use ctrl + k for search-shortcut #3660
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the search shortcut functionality to use ctrl+k instead of ctrl+b. It adjusts the key event detection in the shortcut hook and updates the search button's aria attributes and visual labels accordingly.
- Updated key detection in the shortcut hook to support ctrl+k (while still supporting ctrl+b).
- Changed aria-keyshortcuts and visible text on the search button to reflect the new shortcut.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| aksel.nav.no/website/components/website-modules/search/hooks/useShortcut.ts | Updated keyboard event detection to include "k" alongside "b" |
| aksel.nav.no/website/components/website-modules/search/parts/SearchButton.tsx | Replaced all references of "ctrl+b" with "ctrl+k" in aria attributes and UI text |
|
double edit: nvm, leste ikke tabell entries nøye nok 😳. all is good. (riktig at det er all references innenfor den ene filen) |
Description
https://nav-it.slack.com/archives/C7NE7A8UF/p1741940197954479
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")