-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbedring av vedleggsiden #1364
Merged
ole-kristian-rudjord
merged 28 commits into
main
from
NAV-21855/Forbedring-av-vedleggssiden
Sep 24, 2024
Merged
Forbedring av vedleggsiden #1364
ole-kristian-rudjord
merged 28 commits into
main
from
NAV-21855/Forbedring-av-vedleggssiden
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for barnetsNavn)" This reverts commit 7276d34.
…entasjon mangeler dersom bruker ikke må sende vedlegg
…rer kode-struktur
…tersom disse blir byttet ut med ExpansionCard fra Aksel
thoalm
reviewed
Sep 20, 2024
src/frontend/components/Felleskomponenter/PictureScanningGuide/PictureScanningGuide.tsx
Outdated
Show resolved
Hide resolved
thoalm
reviewed
Sep 20, 2024
src/frontend/components/Felleskomponenter/PictureScanningGuide/PictureScanningExample.tsx
Show resolved
Hide resolved
thoalm
reviewed
Sep 20, 2024
thoalm
reviewed
Sep 20, 2024
src/frontend/components/Felleskomponenter/VedleggOppsummering.tsx
Outdated
Show resolved
Hide resolved
thoalm
reviewed
Sep 20, 2024
src/frontend/components/SøknadsSteg/Dokumentasjon/Dokumentasjon.tsx
Outdated
Show resolved
Hide resolved
thoalm
reviewed
Sep 20, 2024
thoalm
reviewed
Sep 20, 2024
hanneolsen
reviewed
Sep 20, 2024
thoalm
reviewed
Sep 20, 2024
src/frontend/components/Felleskomponenter/VedleggOppsummering/vedleggOppsummeringTypes.ts
Outdated
Show resolved
Hide resolved
thoalm
reviewed
Sep 20, 2024
src/frontend/components/Felleskomponenter/VedleggOppsummering/vedleggOppsummeringUtils.ts
Outdated
Show resolved
Hide resolved
thoalm
reviewed
Sep 20, 2024
thoalm
reviewed
Sep 20, 2024
This reverts commit 92e17cb.
…g tilbake til Dokumentasjon.tsx
thoalm
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🌟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Favro: NAV-21855
💰 Hva forsøker du å løse i denne PR'en
expandableContent
komponent til å brukeExpansionCard
fra Aksel.react-collapse
og@types/react-collapse
dependencies kan fjernes ettersom de ikke lengre tas i bruk.LastOppVedlegg
komponent.✅ Checklist
Jeg har ikke skrevet tester fordi:
🤷♀ ️Hvor er det lurt å starte?
💬 Ønsker du en muntlig gjennomgang?
👀 Screen shots
Obs - små visuelle endringer ble gjort etter at bildene ble tatt:
Før (Tekst-innhold er likt, uavhengig om det er krav om vedlegg eller ikke)
Uten vedleggskrav
Med vedleggskrav
Etter
Uten vedleggskrav
Med vedleggskrav