Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slutt å bruk task som avslutter behandling #1664

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

sillerud
Copy link
Contributor

Den bruker bare database og kan like så greit kjøre i en transaksjon

@sillerud sillerud requested a review from a team as a code owner February 27, 2025 08:14
var behandling = behandlingRepository.findByIdOrThrow(behandlingId)
if (behandling.status == Behandlingsstatus.AVSLUTTET) {
log.medContext(logContext) {
info("Behandling er allerede avsluttet")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
info("Behandling er allerede avsluttet")
info("Behandlingen er allerede avsluttet")

?


if (!behandling.erUnderIverksettelse) {
throw Feil(
message = "Behandling med id=$behandlingId kan ikke avsluttes",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message = "Behandling med id=$behandlingId kan ikke avsluttes",
message = "Behandlingen med id=$behandlingId kan ikke avsluttes",

?

amiraliw
amiraliw previously approved these changes Feb 27, 2025
Copy link
Contributor

@amiraliw amiraliw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut for meg

fredrikmork
fredrikmork previously approved these changes Feb 27, 2025
Copy link
Contributor

@fredrikmork fredrikmork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser greit ut 👍🏼

@sillerud sillerud force-pushed the fjern-avslutt-behandling-task branch from cc937bf to c270a8f Compare February 27, 2025 08:56
Den bruker bare database og kan like så greit kjøre i en transaksjon
@sillerud sillerud dismissed stale reviews from amiraliw and fredrikmork via 404add9 February 27, 2025 09:49
@sillerud sillerud force-pushed the fjern-avslutt-behandling-task branch from c270a8f to 404add9 Compare February 27, 2025 09:49
@sillerud sillerud merged commit 404add9 into main Feb 27, 2025
4 checks passed
@sillerud sillerud deleted the fjern-avslutt-behandling-task branch February 27, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants