TFP-5687: Kall til avslutt kobling returnerer 204 om kobling er allerede avsluttet #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the deactivation endpoint so that it returns a 204 status if the connection is already deactivated, ensuring a safe no-op for redundant deactivation requests.
- The main service now checks if a connection is active before attempting deactivation.
- A new test has been added to validate that no deactivation action is taken and 204 is returned when the connection is already deactivated.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| web/src/main/java/no/nav/foreldrepenger/abakus/kobling/KoblingRestTjeneste.java | Added an active check to differentiate between active and already deactivated connections. |
| web/src/test/java/no/nav/foreldrepenger/abakus/kobling/KoblingRestTjenesteTest.java | Introduced a test case confirming that the endpoint returns 204 when the connection is already deactivated. |
jolarsen
approved these changes
Mar 11, 2025
mrsladek
deleted the
feat/TFP-5687_avslutt_kobling_som_er_inavtiv_allerede
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ellers ville man fått en exception på dette.