Ung: Aksjonspunkt arbeid og inntekt #7240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bort med bruk av tailwind
hallvardastark
changed the title
Diverse styling
Validering
hallvardastark
changed the title
There was a problem hiding this comment.
Pull Request Overview
This pull request aims to remove Tailwind usage from the Ung-beregning module and replace it with CSS modules while introducing adjustments to aksjonspunkt handling and submission callbacks.
- Converted inline Tailwind classes to CSS module classes and updated styling in several UI components.
- Introduced new props such as submitCallback and aksjonspunkter to support aksjonspunkt functionality.
- Updated query hooks and component layouts to align with the new design approach.
Reviewed Changes
Copilot reviewed 20 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| dagsatsOgUtbetaling.module.d.css.ts | New CSS module for DagsatsOgUtbetaling styles. |
| barn.module.d.css.ts | New CSS module for BarnPanel styling. |
| arbeidOgInntekt.module.d.css.ts | New CSS module for ArbeidOgInntekt styling. |
| UngBeregningIndex.tsx | Updated component props to include submitCallback and aksjonspunkter. |
| UngBeregningBackendClient.ts & UngBeregningBackendApiType.ts | Added new API method to fetch kontroll inntekt data. |
| UngBeregning.tsx | Adjusted component logic to handle new API data and aksjonspunkt logic, plus layout adjustments. |
| UngBeregning.stories.tsx | Updated stories to pass new callback prop. |
| UngBarnFakta.tsx | Removed unused component in favor of BarnPanel. |
| DataSection.tsx, DagsatsOgUtbetaling.tsx & BarnPanel.tsx | Updated layout and styling to use CSS modules instead of Tailwind classes. |
| ArbeidOgInntekt.tsx | Major refactoring to include form handling for manual income adjustment and aksjonspunkt rendering. |
| AksjonspunktCodes.ts & BeregningProsessStegPanelDef.tsx | Updated aksjonspunkt codes integration in backend and panel definitions. |
Files not reviewed (5)
- packages/v2/backend/package.json: Language not supported
- packages/v2/gui/src/prosess/ung-beregning/arbeidOgInntekt.module.css: Language not supported
- packages/v2/gui/src/prosess/ung-beregning/barn.module.css: Language not supported
- packages/v2/gui/src/prosess/ung-beregning/dagsatsOgUtbetaling.module.css: Language not supported
- packages/v2/gui/src/prosess/ung-beregning/dataSection.module.css: Language not supported
hallvardastark
commented
Mar 29, 2025
| </Heading> | ||
| <Box maxWidth="75ch"> | ||
| <BodyLong size="small"> | ||
| Jeg fikk forskuttert litt lønn av arbeidsgiver denne måneden fordi jeg har hatt økonomiske |
There was a problem hiding this comment.
Foreløpig hardkodet
hallvardastark
commented
Mar 29, 2025
| <PersonIcon title="Deltager" fontSize="1.5rem" className={styles.personIcon} /> | ||
| <VStack gap="2"> | ||
| <Heading size="xsmall" as="h3"> | ||
| Beskrivelse fra deltaker for avvik i perioden 01.02.2025 - 28.02.2025 |
There was a problem hiding this comment.
Foreløpig hardkodet
vebnor
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Løsning
Kan håndtere aksjonspunkt 8000.
Andre endringer
Fjernet bruk av tailwind i dette panelet
Skjermbilder