Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make root path render last step in Inngang #188

Merged
merged 24 commits into from
Nov 2, 2020
Merged

Make root path render last step in Inngang #188

merged 24 commits into from
Nov 2, 2020

Conversation

cskrov
Copy link
Contributor

@cskrov cskrov commented Oct 19, 2020

Andre applikasjoner bruker root path (klage-dittnav.nav.no/?tema=FOR&saksnummer=123) for å lenke til klagemulighetene.
Root path ble endret til å vise inngangen i PR #183, men tok ikke høyde for query parametere.

Root path (RootwWithQuery) må parse query parametere og ev. saksnummer og delegere videre til LandingPage for å vise enten Inngang (hovedkategorier) for ikke-innloggede brukere eller Klageskjema (begrunnelse) for innloggede brukere.

Større endringer i denne PRen:

  • Ny login redirect path (/loggedin-redirect).
  • Statisk routing for alle hovedkategorier og kategorier. Vi lar routingen håndtere hvilke pather som er gyldige, siden vi vet dette på forhånd.
    • Pga. denne endringen er det fjernet mye logikk i komponentene. De er nå enklere og får det de ellers parset matet inn fra routeren.
  • Hovedkategorier og kategorier er flyttet inn i koden for å gi oss bedre typestøtte og ytelse.
    • Det er også fjernet noen ubrukte properties fra hovedkategoriene og kategoriene. Om vi trenger de senere er de bare legge til igjen.
  • Lagt til URL til papirversjonen av klageskjemaet for FOR.
  • Lagt til komponentene RootWithQuery og LandingPage for å håndtere andre løsninger som bruker legacy URLer (klage-dittnav.nav.no/?tema=FOR&saksnummer=123).
  • Fjernet referrer over alt.

@cskrov cskrov marked this pull request as draft October 19, 2020 15:13
@cskrov cskrov changed the title Make root path render klageskjema Make root path render siste steg i skjemavelgeren Oct 19, 2020
@cskrov cskrov force-pushed the fix-root-route branch 3 times, most recently from 1cbe84e to 2c2d825 Compare October 19, 2020 16:26
@cskrov cskrov changed the title Make root path render siste steg i skjemavelgeren Make root path render last step in skjemavelgeren Oct 20, 2020
@cskrov cskrov force-pushed the fix-root-route branch 2 times, most recently from 9ba4645 to 7d0446a Compare October 20, 2020 09:28
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 20, 2020 09:34 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 20, 2020 11:12 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 20, 2020 11:38 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 20, 2020 16:58 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 21, 2020 07:12 Inactive
@cskrov cskrov force-pushed the fix-root-route branch 4 times, most recently from 1395363 to da294b5 Compare October 21, 2020 11:51
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 21, 2020 12:14 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 21, 2020 12:46 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 22, 2020 08:46 Inactive
@cskrov cskrov force-pushed the fix-root-route branch 4 times, most recently from 8f2130b to 68cfd12 Compare October 27, 2020 14:54
@cskrov cskrov changed the title Make root path render last step in skjemavelgeren Make root path render last step in Inngang Oct 27, 2020
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 28, 2020 14:22 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 30, 2020 10:07 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 30, 2020 10:13 Inactive
@cskrov cskrov marked this pull request as ready for review October 30, 2020 11:18
@cskrov cskrov force-pushed the fix-root-route branch 2 times, most recently from 66afba0 to 2bdb994 Compare October 30, 2020 14:12
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 30, 2020 14:16 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 30, 2020 14:23 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 30, 2020 14:53 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage October 30, 2020 15:11 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage November 2, 2020 11:32 Inactive
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage November 2, 2020 11:42 Inactive
mahval
mahval previously approved these changes Nov 2, 2020
@nais-deploy nais-deploy bot temporarily deployed to dev-gcp:klage November 2, 2020 14:01 Inactive
@cskrov cskrov merged commit 7bc4f08 into master Nov 2, 2020
@cskrov cskrov deleted the fix-root-route branch November 3, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants