Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oasis #529

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Oasis #529

merged 1 commit into from
Mar 18, 2025

Conversation

eriksson-daniel
Copy link
Contributor

No description provided.

@eriksson-daniel eriksson-daniel force-pushed the oasis branch 5 times, most recently from 57f7bfd to 2e9464e Compare March 18, 2025 07:32
@eriksson-daniel eriksson-daniel changed the title wip Oasis Mar 18, 2025
@eriksson-daniel eriksson-daniel force-pushed the oasis branch 4 times, most recently from 3fde5a0 to 66f730f Compare March 18, 2025 08:06
@eriksson-daniel eriksson-daniel marked this pull request as ready for review March 18, 2025 08:17
@Copilot Copilot bot review requested due to automatic review settings March 18, 2025 08:17
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR, titled "Oasis", refactors the authentication middleware by replacing the old TokenX and persistent caching logic with a new flow based on the Oasis library. Key changes include the following:

  • Updates to token request logic in the obo-token plugin to use the Oasis library’s requestOboToken and validateToken functions.
  • Removal of legacy token-x client, persistent cache, and related gauges and types.
  • Minor configuration and server startup adjustments to support the new authentication flow.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
server/src/plugins/obo-token.ts Adjusted token retrieval logic and added a check for apps excluded from OBO.
server/src/config/config.ts Removed legacy token-x configuration and local JWK.
server/src/server.ts Removed initialization call previously used for token-x client setup.
nais/nais.yaml Removed obsolete Redis valkey configuration.
server/src/plugins/health.ts Removed health check for token-x client and OBO cache readiness.
Remaining auth/cache and token-x files Deleted legacy implementations now replaced by the new Oasis logic.
Comments suppressed due to low confidence (2)

server/src/plugins/obo-token.ts:64

  • The previous implementation provided a fallback to the cache via oboCache.getCached(getCacheKey(...)). Please verify that removing the cache fallback is intentional and that the new logic fully covers the required caching functionality.
return this.oboAccessTokenMap.get(appName);

server/src/server.ts:64

  • The call to init() has been removed from the server startup. Confirm that this removal is intentional and that any required initialization logic has been migrated to the new flow.
// Initialize.
// init();

@eriksson-daniel eriksson-daniel merged commit 4ac61c4 into main Mar 18, 2025
4 checks passed
@eriksson-daniel eriksson-daniel deleted the oasis branch March 18, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants