Saksnummer #530
Merged
Saksnummer #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriksson-daniel
force-pushed
the
saksnummer
branch
9 times, most recently
from
fb4a142 to
e8aba41
Compare
eriksson-daniel
force-pushed
the
saksnummer
branch
3 times, most recently
from
e1e4dab to
d37fa02
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates how case identification parameters are handled by replacing legacy fields (internalSaksnummer and caseIsAtKA) with a new DyplenkeParams interface. Key changes include updating type definitions to extend DyplenkeParams, modifying session handling and query parameter extraction accordingly, and updating related API and UI components to reflect the new structure.
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/redux-api/case/types.ts | Updated interface definitions and replaced legacy fields with DyplenkeParams. |
| frontend/src/components/case/uinnlogget/session-loader.tsx | Extracted additional query parameters and refactored session case initialization. |
| frontend/src/routes/create-case/handlers.ts | Adapted session, create, and resume handlers to use DyplenkeParams. |
| frontend/src/components/case/common/saksnummer.tsx | Refactored components for displaying saksnummer based on availability. |
| frontend/src/routes/create-case/use-case.ts | Updated hook dependencies and propagation of DyplenkeParams. |
| frontend/src/redux/session/klage/reducers.ts | Revised session reducer logic to merge new dyplenke parameters consistently. |
| Others (params.ts, helpers.ts, logging, api, types, hooks) | Propagated changes across case API, session helpers, logging messages, etc. |
Files not reviewed (1)
- frontend/package.json: Language not supported
eriksson-daniel
force-pushed
the
saksnummer
branch
4 times, most recently
from
c08fe0b to
fff1602
Compare
eriksson-daniel
force-pushed
the
saksnummer
branch
from
fff1602 to
861af08
Compare
cskrov
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.