support https in all server types #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tommytroen
commented
Jun 8, 2021
tommytroen
commented
- enables HTTPS on the mock-oauth2-server if specified on the server types:
- MockWebServer
- Netty
- bring your own keystore or let the server generate one for you
* enabled by providing Tls constructor param with external keystore
* enabled by providing Tls constructor param with external keystore
* introduce BouncyCastle for cert generation
…tFactory * remove typo
* allow to byo keystore or generate * make Ssl non-private in order to retrieve the keystore when testing against the generated server cert
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Scan Summary
| Tool | Critical | High | Medium | Low | Status |
|---|---|---|---|---|---|
| Dependency Scan (java) | 0 | 0 | 1 | 1 | ✅ |
| Dependency Scan (kotlin) | 0 | 0 | 1 | 1 | ✅ |
| Secrets Audit | 0 | 1 | 0 | 0 | ❌ |
| Kotlin Static Analysis | 0 | 0 | 4 | 0 | ✅ |
Recommendation
Please review the findings from Code scanning alerts before approving this pull request. You can also configure the build rules or add suppressions to customize this bot 👍
tommytroen
added
enhancement
jksolbakken
reviewed
Jun 8, 2021
src/test/kotlin/no/nav/security/mock/oauth2/e2e/MockOAuth2ServerIntegrationTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.